Skip to content

[MAIN] Libzerocoin patch#390

Merged
Mrs-X merged 2 commits into
PIVX-Project:masterfrom
presstab:libzerocoin_patch
Nov 13, 2017
Merged

[MAIN] Libzerocoin patch#390
Mrs-X merged 2 commits into
PIVX-Project:masterfrom
presstab:libzerocoin_patch

Conversation

@presstab
Copy link
Copy Markdown

  • This patches up the recent exploit that was found in 3rd party library libzerocoin. The exploit allowed for multiple serial #'s to be created from a single minted zerocoin and still be considered valid.

  • Accumulators are triggered to be recalculated to exclude any mints that stem from invalid spends. This recalculation will occur on block 908000. Accumulator checkpoints that were added while invalid spends/mints were made will be deleted from the database automatically.

  • The money supply (both PIV and zPIV) will be reindexed automatically on block 908001.

  • -reindexmoneysupply startup flag has been added which will recalculated the money supply on startup.

  • getinfo and getblock RPC now print the zPIV supply for each zPIV denomination.

  • Checkpoints are added in spots where the network saw disagreement and lack of consensus.

  • An additional, and redundant, check is added that ensures zerocoinmint transactions are seen as unspendable by CCoins. (unrelated to exploit, but an additional safety check).

  • This specific pull request has zPIV transactions hard coded to be disabled. It is important to note that [Main] Allow for zPIV maintenance mode #388 should be applied after this PR to have proper functionality.

  • Any stolen funds that were not reaccumulated as zPIV will be locked, with the exception of funds that were filtered through Bittrex.

  • Protocol is bumped to 70912

  • Spork_11 is added.

@ghost ghost assigned presstab Nov 13, 2017
@ghost ghost added the review label Nov 13, 2017
@PIVX-Project PIVX-Project added this to the 3.0.5 milestone Nov 13, 2017
@presstab presstab changed the title Libzerocoin patch [MAIN] Libzerocoin patch Nov 13, 2017
@Mrs-X Mrs-X merged commit 02fe7cc into PIVX-Project:master Nov 13, 2017
Mrs-X added a commit that referenced this pull request Nov 13, 2017
02fe7cc Post libzerocoin patch consensus adjustments and supply fix. (presstab)
0d2b055 Patch libzerocoin. Invalidate spends with bad proofs. (presstab)

Tree-SHA512: 85c57977b7565fb8eff55c368011e62ede2a96ada27c54fcea169bac1feef2f875ff658152476434e2503ebdd50a6337fc3287e21ea5a789a19c43a745e4c5c6
@ghost ghost removed the review label Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants