[MAIN] Libzerocoin patch#390
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patches up the recent exploit that was found in 3rd party library
libzerocoin. The exploit allowed for multipleserial #'s to be created from a single minted zerocoin and still be considered valid.Accumulators are triggered to be recalculated to exclude any mints that stem from invalid spends. This recalculation will occur on block
908000. Accumulator checkpoints that were added while invalid spends/mints were made will be deleted from the database automatically.The money supply (both PIV and zPIV) will be reindexed automatically on block
908001.-reindexmoneysupplystartup flag has been added which will recalculated the money supply on startup.getinfoandgetblockRPC now print the zPIV supply for each zPIV denomination.Checkpoints are added in spots where the network saw disagreement and lack of consensus.
An additional, and redundant, check is added that ensures
zerocoinminttransactions are seen as unspendable byCCoins. (unrelated to exploit, but an additional safety check).This specific pull request has zPIV transactions hard coded to be disabled. It is important to note that [Main] Allow for zPIV maintenance mode #388 should be applied after this PR to have proper functionality.
Any stolen funds that were not reaccumulated as zPIV will be locked, with the exception of funds that were filtered through Bittrex.
Protocol is bumped to 70912
Spork_11 is added.