[Qt] Feature: Added controls to the overview page for enable or disable auto-minting and set required level

[lex-dev1]

This is the implementation of the feature request #433. Solution has control in the overview page for enable or disable auto-minting and set required level.

This is an updated PR, previous discussion here

[Fuzzbawls]

now that this is it's own PR, I'll restate the opinion that I don't feel buttons on the overview tab is a very good idea from a design perspective.

While I agree that the information as to the status of automint and an accessible way to quickly open up the options dialog to change it is good, The placement on the overview tab just seems off to me.

[Mrs-X]

I agree with @Fuzzbawls , after all it's a Overview page, and the left side is quite crowded already.

We'd start with one button, and in no time there'd be buttons all over the place.

[datasubsystems]

@Fuzzbawls @Mrs-X I was asked by @s3v3nh4cks to work on this request. I didn't pick it myself. Clearly this was requested by multiple community members (#433). I'm not sure why it's not easy to understand the frustration of the first time user who just sent some PIV from exchange to the wallet and seeing PIV balance drop without consent. There is absolutely no way new user would read any release notes (as @presstab properly noted in prior discussion) or open "privacy" tab right away or understand what's going on. I experienced a feeling of been tricked as well when I first seen minting happening without my consent. I'd like to emphasize that I set minting to enabled state by default as was requested (with a hope that zPIV staking is coming soon and overcoming personal disagreement with this automatically enabled conversion) because I understand that this is done to support new zPIV feature that needs more minting at this time. I already received thanks notes in direct discord messages from community members for finding at least partial solution for this issue that generates ton of support requests. Currently overview is the page that everyone can see on the first wallet load and it's the least evil remedy for the hidden zPIV minting that is happening without any understanding or consent of a new pivx user).

[veramispotato]

Because of how well you designed the autominting startup notification (Thank you, Lex!), I think that could be very effective just by itself, and personally I would be more than happy if that was all we got.

Coupling startup notification with a zPIV autominting button on Overview would make even fewer people get confused, but I can see both sides of the argument for whether or not we give some space on Overview tab for it. Maybe if it was an enable/disable button in the first page of Options? Then it could be easy to see/access, but we don't have to worry about taking any space on the Overview tab.

I personally think the startup notification you made will be very good and may be more than adequate until zPIV staking comes and we disable zPIV autominting. And after that, we can also remove the startup notice and notice in pivx.org/wallet and make things cleaner. But I think it's really great we're doing more to make PIVX as user-friendly as possible! Love that new wallet UI :).

[datasubsystems]

Hey @wholewheatbiscuits Can you discuss with devs what needs to be done exactly and have someone from devs explain to me specifically what needs to be done to help first time user understand on a first wallet load that some PIV is about to be converted to zPIV? Pop-up is not implemented as it can be annoying. Any alternative solutions guys?

[veramispotato]

@datasubsystems Oh. I thought startup pop-up was being implemented. In that case, how about if the zPIV autominting notification only pops up IF a user is making a brand new wallet.dat? It doesn't have to be a "pop-up" either, but rather, built into a "step-by-step wallet setup" guide. Please refer to the first few pictures of how Monero guides users through setting up a wallet (this guide ONLY shows up when Monero detects that a user has no wallet in the wallet directory and makes a new one).

https://imgur.com/2PVT1wX

[turtleflax]

I'm highly in favor of additional notification to the user about the automint. If a button on that tab is objectionable, perhaps just an indicator of the current percentage would suffice with a hover tooltip about where to adjust it in Tools>Options? I would also highly recommend an indication of the setting on places where the user can trigger the automint like the Unlock window, send tab, or privacy tab.

Even if the automint is possibly going away in a few months, I think this would be beneficial until that time.

Also +1 for the FirstRun popup but I've already said my part on that in 433

[Warrows]

I'll side with @Fuzzbawls and @Mrs-X in that I think a button on the overview page is too much. Especially given that the option is available in settings now (#465). However it's true the autominting is generating a lot of support requests and first time users need more education. I believe the best solution would indeed be a pop-up window when starting the software for the first time (or like @wholewheatbiscuits suggested on wallet.dat creation). This would simply state something like "By default your wallet is going to mint 10% anonymized zPIV. To change this, head up to settings."

[rejectedpromise]

@lex-dev1 :
please go through this process -- https://help.github.com/articles/generating-a-new-gpg-key/

to provide verified commits

[Fuzzbawls]

After the discussion above, and internal discussions, I'm going to have to give this a firm NACK in it's current implementation.

Firm NACK to the idea of adding buttons to the overview page in general. While the concept of having this information be more readily accessible is sound, the overview page is not the place for it.

Consider moving the icon/button/etc to the status bar instead, which is accessible regardless of what UI tab is currently being displayed.

[rejectedpromise]

@lex-dev1 do you plan on continuing to work on this issue?

[Mrs-X]

Also NACK from my side.

The most important feature, having an AutoMint switch in the UI, is already implemented with #465 , and there's no feedback for this PR here from the author for 30 days now, so it's a valid assumption that he has discarded this PR.

[Fuzzbawls]

Closing this for now.

If interest is renewed and concerns/feedback addressed then it can be reopened.

[rejectedpromise]

Also NACK on my end from lack of activity and already implemented by core 🤷‍♂️