forked from dashpay/dash
-
Notifications
You must be signed in to change notification settings - Fork 720
[GUI] [Model] New Wallet UI #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
random-zebra
merged 373 commits into
PIVX-Project:master
from
furszy:new_gui_rebased_final
Sep 10, 2019
Merged
Changes from all commits
Commits
Show all changes
373 commits
Select commit
Hold shift + click to select a range
4a5531e
coin control focus and alternate color removed.
furszy 42edeff
topbar icons connected to the backend.
furszy e4ba616
style and elements tree widget added
Neoperol 125888e
coin control tree widget root decoration
furszy 350b168
style options button changed
Neoperol ab61f2a
dashboard unconfirmed row icon
furszy 950ee47
pixelated pixmap icons fixed.
furszy a601eea
Layout fixes in send, settings display and resources warning fixes
Neoperol 602a692
tooltip menu generalization.
furszy 4bc2b59
status warninng sync dashboard added, warning layouts removed
Neoperol 4cec67e
send multi outputs, tooltip menu + delete row connected.
furszy 384c028
send screen, contacts dropdown position on multi output fix
furszy 7aedcbf
Layout changes, in main window, address and privacy view
Neoperol 4169e8a
Layout warning changed
Neoperol 3c7cde5
dashboard warning icon.
furszy 021a44d
Progress sync added
Neoperol 208ba52
topbar progress bar connected to sync widget.
furszy bca6b66
loading dialog created.
furszy 7eb575f
topbar generalized to pwidget.
furszy 196da4c
loading dialog + runnable tasks object
furszy 229a59f
move encrypt wallet to background task.
furszy cacce31
change theme, dark mode initial connection.
furszy 03e12d3
css style dark.
furszy 13650d3
button show password
Neoperol f21fd8f
privacy image added
Neoperol 96915f8
style dark mode changed
Neoperol d5c592d
coincontrol dark mode fixed
Neoperol 4eb1ee5
dark mode improvements all over the UI.
furszy 1605e65
wallet sync signal connected to dashboard warning, askkpassphrasedial…
furszy 062403c
Style dark changes
Neoperol e6efef9
Icons console changed
Neoperol c75ffb7
Icons darkmode added
Neoperol 316977a
signal changeTheme name changed to not override parent slot
furszy 81d5a72
background loading crash fixed.
furszy 1b0a804
qtcharts lib integrated.
furszy c3455f9
console update theme
furszy 1304c66
tx row, use tx model flow instead of direct access.
furszy b862f6a
dashboard stakes chart connected (main logic left)
furszy 2371229
wallet sync warning visible/invisible + minor UI modifications.
furszy 1fef880
passphrase dialog edit line echo mode on click change fixed + dashboa…
furszy 3b97499
transaction size calculation method created + connected to the tx rec…
furszy ca834b0
create/update contact from the send multi screen fully functional.
furszy 766426f
send screen, tooltip menu width and remove one by one entry fix
furszy 4af6af8
backup screen, texts changed.
furszy c48a417
update send screen balance on every entry.
furszy 0c18316
amount entry max range.
furszy 09e87cc
tx detail, show inputs connected.
furszy 1927ca7
null chart change theme fix
furszy 915ca4d
Loading resources added
Neoperol b4b0215
[GUI] tx detail dialog outputs connected.
furszy ca7d069
[GUI] coincontrol dialog ok button style.
furszy d60bfbb
layout send changed
Neoperol 465b055
Layout confirmation changed, copy button added
Neoperol 7e40e4f
Icon copy changed
Neoperol f1fa289
[GUI] txdetail dialog inputs organized in grid layout.
furszy d1a7107
[GUI] snackbar generalized + txDetailDialog copy id event connected.
furszy c6bb3db
[GUI] dashboard stakes PIV chart color.
furszy 1599a40
[GUI] settings sign message connected.
furszy cefcd9f
Sign layout changed
Neoperol 72cb7cf
[GUI] settings sign screen addresses dropdown connected.
furszy d4a4c39
[GUI] QLineEdit selection color and background changed.
furszy 213637d
Send layout changed
Neoperol a7b7041
[GUI] welcome tutorial go back between screens fixed
furszy d11d1b7
[GUI] bip38 encrypt screen connected.
furszy a26563a
[GUI] hide dialog on loading action.
furszy 54a240b
[GUI] loading text animation.
furszy 49fd73b
[GUI] information and warning standard qt dialog in askpassphrasedial…
furszy 77462d8
Layout coincontrol changed
Neoperol 1bbf8c4
zPiv coincontrol layout changed
Neoperol 84ffada
[Model] isWalletUnlocked method created.
furszy ed9702b
[GUI] check if the wallet is unlocked to perform certain actions + UI…
furszy 68edadb
[GUI] Address table model update amount of send/receive address.
furszy 271d0f1
[GUI] welcome tutorial texts changed.
furszy 8147fc2
Send layout changed
Neoperol 317b7be
Layout space changes
Neoperol e8f1ea6
layout request changed
Neoperol 7ea6798
Style and layout changes
Neoperol ec300f4
[GUI] request dialog layout organization + send layout change
furszy 9d42541
[GUI] dashboard txes sort fixed.
furszy 3032c83
[GUI] send confirmation dialog, not show outputs when there is only one.
furszy ac1cfb5
[GUI] styles fixed from a bad rebase.
furszy ba8634d
[GUI] Store size of zc txes.
furszy c1446ba
[GUI] empty view when no zc txes.
furszy 676b48d
[GUI] request dialog address not updated fix + layout reorg.
furszy fd63c44
[GUI] privacy widget cleanup + no coin inputs notifications.
furszy bdebe41
[GUI] comma char replaced thin space on html formatted balance.
furszy 98eab47
[GUI] win stake tx amount color fix.
furszy b1efc22
[GUI] dashboard chart re organization.
furszy c74e884
style changes
Neoperol 014df06
[GUI] dashboard chart, days in months connected.
furszy 12e7906
Combobox arrow style and
Neoperol 000b82c
[GUI] openuridialog buttons style, code cleanup + encryptionStatus ev…
furszy 1f2e36a
Style combobox settings changed
Neoperol 90f107d
[GUI] hide multi outputs for zPIV spend + dashboard refresh chart on …
furszy bccaebd
[Deployment] fix bad link order.
furszy e1c1014
[GUI] contacts dropdown change theme.
furszy 40f084c
[Model] block zpiv mints from the ui.
furszy 6f15b52
[WalletModel] wallet first key creation time method implemented.
furszy 37f2f44
[GUI] dashboard staking chart, year and month filters + chart logic.
furszy 5ec1e79
Style chart added
Neoperol c02499e
style combobox chart changed
Neoperol 47520da
[GUI] chart combobox rounded borders.
furszy 3ef02a9
style combo-secundary added, group title added
Neoperol 8aaf00f
[GUI] chart sort and filter controls style improved.
furszy 9444e85
[GUI] dashboard, staking chart style margin fix.
furszy d67df85
[GUI] dashboard staking chart, move chart position flow.
furszy 4d5ff36
[Tx Model] tx arrive signal, tx hash added.
furszy 059d39f
[WalletModel] isCoinStake method added.
furszy 45d0471
[GUI] dashboard, only update chart when stakes arrive.
furszy d9e79be
Chart buttons style changed
Neoperol a22c487
[GUI] dashboard hasStakes method.
furszy 39c5bbb
layout chart, and style buttons changed
Neoperol c5bc680
[GUI] chart sort by buttons expanded.
furszy aaf98e5
Arrow back chart added
Neoperol e2cd6c8
[GUI] dark theme invalid icons name fix.
furszy d83b1b1
[GUI] layout reorg, duplicate arrow on comboBox fix.
furszy d031f68
[GUI] dashboard chart arrow style.
furszy ac865b1
style dark mode style settings fixed
Neoperol 1447ef0
[GUI] FAQ resizable.
furszy d8335c4
Receive error fixed
Neoperol 14816c4
[GUI] MN screens ui coded (not connected) + pwidget constructor cleanup.
furszy 6f1992b
[GUI] tooltip texts generalized.
furszy 42337ad
[GUI] master nodes model + new screen implemented.
furszy 8230a44
[GUI] Delete single master node implemented.
furszy cf9f8e9
[GUI] master nodes screen, subtitle and MN info.
furszy 775053d
[GUI] topbar lock btn open non perfect opening fixed.
furszy 9006da9
[GUI] receive address screen, change address label dialog text correc…
furszy 53c199f
[GUI] navmenu code better abstracted.
furszy 259e367
[GUI] verifyWalletUnlocked method implemented.
furszy dc24786
[GUI] dashboard change theme, staking graph fix.
furszy aeeef1c
[Model] no swiftTx by default.
furszy 5efbba2
[GUI] master nodes model and creation wizard.
furszy 137aa2e
[REBASE] rebase issues solved.
furszy ec70fed
[GUI] FAQ, MN description added.
furszy ebb43fb
[GUI] openFaq method created.
furszy 3610af1
[GUI] MN model, update list + get master node internal data.
furszy b40d05d
[GUI] Master nodes flow, MN info dialog created and connected.
furszy 0d911df
[GUI] Master node list update timer.
furszy 8824a19
[GUI] minor snackbar dialog delete.
furszy e4d17b6
FAQ icon added
Neoperol e386b66
[GUI] dashboard staking chart, change theme y axis color.
furszy 3014d9b
[GUI] payment request dialog open fix + copy URI connected.
furszy e08cf3b
[GUI] send screen, parse URI.
furszy 97546ad
[Cleanup] not used zpiv coin control dialog removed.
furszy 2719ddf
[GUI] Send, add new entry validation.
furszy 85ef032
[GUI] send screen, multi outputs validations
furszy 5cebcfd
[GUI] Sign/Verify flow fully connected.
furszy 4c9a162
[GUI] settings widget layout improvements.
furszy 9e92e10
[GUI] MN wizard mode texts included.
furszy c762cc3
[GUI] settings tools, bip38 layout and encription.
furszy 661904c
[GUI] settings wallet, multiSend layout organization improved.
furszy 38ebf90
[GUI] settings tools sign/verify completed.
furszy bb19862
[GUI] Send screen, open URI from file connected.
furszy cf59e12
[GUI] faq + multisend layout minor reorg
furszy 494afeb
[GUI] askpassphrase dialog wrap title.
furszy 7c7035b
[GUI] settings widget, only one option checked at time.
furszy 235e23d
[GUI] settings options, re organization + code cleanup.
furszy f85d1f6
[GUI] settings duplicate option name changed.
furszy 014e2e6
[GUI] tx detail, title correction.
furszy afe44bc
[GUI] About and commands dialog connected.
furszy 336e3f9
[GUI] settings options re organization.
furszy 621198d
Layout settings main changed, texto style added
Neoperol 84668f5
[GUI] Default dialog visible when the screen is not visible.
furszy f7be74e
[GUI] dashboard, update chart only with own stakes + cleanup.
furszy 2b8ea8d
[WalletModel] set wallet default fee method created.
furszy fb70996
[GUI] Custom fee option connected on send screen.
furszy b21956d
[GUI] Minor layout corrections in custom fee dialog and tools sign me…
furszy 1ba730d
[Cleanup] Continuing with the final cleanup, setProperty methods move…
furszy d217799
[GUI] Contacts screen, add contact -> notify about an already existen…
furszy 7010862
Layout intro app changed
Neoperol 0b84005
Background and layout changed
Neoperol db994e9
[GUI] Intro dialog new style finished.
furszy db73d9e
[GUI] Intro dialog minor corrections.
furszy f4ce128
[GUI] send row hover style minor fix and smart fee update connected.
furszy f83ad71
[GUI] enabled/disabled editable status added.
furszy 639d14d
[GUI] Master nodes wizard creation, only controller flow.
furszy 6825fab
[GUI] Master nodes wizard input validations + code cleanup.
furszy 65c93b0
[GUI] settings/tools bip38 decrypt connected.
furszy 2126b04
[GUI][Model] MultiSend functionality fully revamped and connected.
furszy 460489f
[GUI] receive address padding overlapping text fix.
furszy 1745fae
[GUI] topbar lock, not perform any action if the wallet is already on…
furszy 238e276
[REBASE] rebase fixes.
furszy 7d2820e
[GUI] payment request dropdown style fix.
furszy b9f6d43
[GUI] styling improvements, css class property set cleanup.
furszy 911966b
[Build] build system QT fixes + duplicated moc object fix.
furszy ed1515e
[Build] travis new wallet dependencies added.
furszy 387d83e
[Build] qt missing-img-files, fixing rebase inserted issues.
furszy 0e5070e
[Model] Invalid iterator position crash fix.
furszy dad5c97
[UI] series removal not cleaning the charts pointer fix.
furszy 950524a
[Trivial] PIVX license header.
furszy e3cbae3
[Doc] New dependencies for ubuntu QT build added.
furszy 57a1b60
[Build] gitian-qt
furszy 3c94867
[GUI] Request dialog storing address label + description text layout …
furszy c477e9b
[Wallet][Model] GetKeyCreationTime moved from walletModel into the wa…
furszy 6abfe3a
[GUI] My address row set date if exists.
furszy 5850de0
[GUI] Settings information minor layout fix + code reorg and refactor…
furszy 45cbe2c
[Model] Only look for the creation time for internal addresses
furszy d4a7316
[GUI] Show dialog correct title + MN show/hide screen checkbox removed.
furszy 404059d
[Trivial] Further small wording tweaks
CaveSpectre11 1af2b07
[GUI] stake spin box range + settings console not returning values fi…
furszy 365f9fe
[GUI] settings display options show display unit fix, settings inform…
furszy f855afc
[GUI] Master nodes screen, FAQ opening MN section.
furszy 173a833
[GUI] open/close option button arrow icon connected.
furszy 239b599
[GUI][Model] Settings options reset.
furszy ac69ee4
[Model] isTestnet method created, abstracting the UI from backend dep…
furszy 78979f2
[GUI] FAQ rounded btns.
furszy 0e8eff1
[Model][MasterNodes] Master node MISSING status added, only happens w…
furszy 4a66dd1
[GUI] Master node screen improvements:
furszy 8f935d1
[GUI] Contacts screen, update list view and empty screen when contact…
furszy 9aa97f1
[GUI][Model] Settings options, mechanism to discard options that were…
furszy 1ebb669
[Wallet][Model] Badly nStakeSplitThreshold set in optionsModel fixed …
furszy 0f80422
[GUI] dashboard staking chart, prevent series added twice.
furszy 866415e
[GUI] Send screen, total remaining label modified to show the coin co…
furszy 79d131d
[Model] isCoinStakeMine method validating against the tx input instea…
furszy 1732ad3
[GUI] Dashboard screen:
furszy eea027a
[GUI][Model] Masternodes screen, export Masternode data for remote se…
furszy 3d54f90
[GUI][Model] Masternodes screen:
furszy d4bc144
[GUI] tx detail dialog closing delay solved + cleanup.
furszy f3a6e2c
[GUI] Dashboard screen, hide tx filters when the wallet doesn't have …
furszy 9809f00
[GUI][Model] Masternodes screen, verify if masternode collateral tx w…
furszy 70dd159
[GUI] AskPassphraseDialog, missing opaque background on dialog popup …
furszy 680d2dd
[GUI] notify user when the system doesn't have a predetermined text e…
furszy 1d07968
[GUI] Hack to re paint the chart view for linux. The chart was not up…
furszy 9cb8f64
[GUI] Update coin control style when the theme changes.
furszy 57ca1b4
[GUI] Linux QComboBox listView items internal invalid focus square re…
furszy b233081
[GUI] Settings multisend, list missing container style.
furszy 05594c8
[REFACTOR] Code refactor forced by #949. "Using namespaces" statement…
furszy d89de01
[Trivial] Cleanup UI compile warnings
CaveSpectre11 891f64d
[GUI] Settings trailing spaces + minimize layout vertical expansion.
furszy 6698d0b
[GUI] Settings multiSend, request wallet unlock before add or delete …
furszy 3675f2e
[GUI] * processNewTransaction method connected to dashboard screen, p…
furszy fb9b7e6
[GUI] welcome tutorial, typo fixed + privacy and MN text changed.
furszy 62e06f2
[UI] Wallet sync state, pending icon and style added to the transacti…
furszy 85dc691
[GUI] Fix connectSlotsByName errors
CaveSpectre11 bb1a743
[GUI] Cleanup build warnings
CaveSpectre11 f23a8f9
[UI] Open uri dialog, invalid place holder text removed.
furszy dcbfe17
[Build][UI] Provisional move of the QTCharts library to optional depe…
furszy 07d5a6e
testnet flag disabled
furszy 4f6c6cb
[Travis] qrencode no longer optional added to host x86_64-unknown-lin…
furszy 56074a2
[Helpers] Invalid conversion from ‘const char*’ to ‘uint {aka unsigne…
furszy e40ea11
[UI] Forced reset to activate the settings options custom values conn…
furszy 30e7c1e
[Refactor] * Capitalized PIVXGUI and AddressFilterProxyModel filename…
furszy 8029464
[refactor] lowercase files
furszy b19cbaf
[Revert] bad method name change reverted, debug console enter button …
furszy c812429
[GUI] Abstract background thread process flow created, dashboard char…
furszy 06ee910
[Trivial] Compiler warnings, not used variables.
furszy 1e0a347
[UI] - When clicking unlock/lock wallet, the password get edit text g…
furszy c07c9b3
[UI] NavMenu, app's version connected.
furszy 3c711ef
[Trivial] transactionTableModel foreach using const variable instead …
furszy ca046aa
[UI] - Dashboard chart load, min update time interval, not update vie…
furszy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest not adding
Qt5Svghere.On my system (debian without Qt5Svg) removing this leads configure (with
--with-gui) to fail withconfigure: error: qtsvg not foundwhile with this the error message is more generic:configure: error: Qt dependencies not found.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qt5svg is mandatory now. Have updated the dependencies doc with it.
Explanation:
Our wallet is fully responsive now, every icon and drawable resource can be resized depending on the screen density (xml scalable vectors that we can expand or minimize programmatically, SVG resources).
Previous wallet used only png resources, which were blocking any good quality screen resize. png force the wallet to have one icon/image file per screen density, instead of programmatically resize the same unique file, increasing the amount of required resources in different sizes for different screen densities inside the wallet or it will get pixelated and decrease its quality a lot.
In linux qt5svg is supported in every distribution that i have tried, you just need to download
libqt5svg5-dev.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but this line makes it so that the configure script doesn't tell you that qtsvg is missing.
I think removing it from here shouldn't be a problem since it's checked else where on its own. Unless I missed something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm ok, it's validated in other place but I'm not so sure if we can remove it from there, if qt5_modules is a global variable used in some other places then it should be checked before that line and not be removed. Will check it.
Still, i wouldn't spend too much time around this. People will always first read the build-xxx.md doc, which states the svg dependency anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/always/eventually;)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Qt5Svg is indeed checked elsewhere and shouldn't be included in this particular line, who's purpose is to only check the top level Core Qt modules (those available/provided by the Qt5Base package).
So here, the Core modules are checked first, then (if present), additional modules and supporting libraries are checked elsewhere.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot argue much against our build system champ, will remove it from that line then 👍 .