[Trivial][Tests] Do not fail test when warnings are written to stderr#961
Merged
Merged
Conversation
|
utACK e71bafd |
|
ACK ,tested on the pr which had this issue,travis shows checks successful. |
Fuzzbawls
reviewed
Jul 26, 2019
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
Looks good overall, just a couple output format nits
print stderr with the test result instead
random-zebra
force-pushed
the
2019_test_runner
branch
from
e71bafd to
20aab11
Compare
Fuzzbawls
approved these changes
Jul 28, 2019
Warrows
approved these changes
Jul 31, 2019
random-zebra
added a commit
that referenced
this pull request
Jul 31, 2019
…en to stderr 20aab11 [Tests] Do not fail when warnings are written to stderr (random-zebra) Pull request description: Fixes #960 Rationale: the test result should be set only through `assert`s in the test and not rely on what's printed on the console. Furthermore, as shown in the issue, stderr could contain simple warnings that don't affect the test's outcome. If stderr is not empty though, print its content. Also re-sort tests by duration. ACKs for top commit: Fuzzbawls: ACK 20aab11 Warrows: utACK 20aab11 Tree-SHA512: 34685dd81b7849d761eb3427a3f67c825605b58d985d3c992491007ac84085632b6c5a24427ac53e8c6f340b3becf68e5b0a036bf2614b47f20ab9886b027432
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #960
Rationale: the test result should be set only through
asserts in the test and not rely on what's printed on the console. Furthermore, as shown in the issue, stderr could contain simple warnings that don't affect the test's outcome.If stderr is not empty though, print its content.
Also re-sort tests by duration.