[Miner] Don't create new keys when generating PoS blocks#982
Merged
random-zebra merged 1 commit intoAug 14, 2019
Merged
Conversation
key creation for coinbase output is a waste for PoS blocks and can be removed
random-zebra
force-pushed
the
2019_CreateNewBlockWithKey_move_reserveKey
branch
from
f7d980a to
74e7fc7
Compare
random-zebra
changed the title
|
Took a minute to follow; but then recalled the signature that ends up in tx[0] vout[0]. utACK 74e7fc7 |
|
utACK 74e7fc7 |
random-zebra
added a commit
that referenced
this pull request
Aug 14, 2019
74e7fc7 [Miner] Don't create new keys when generating PoS blocks (random-zebra) Pull request description: This fixes the calls to `CreateNewBlockWithKey` with PoS blocks, which are not needed. We simply call `CreateNewBlock` with an empy script for coinbase. It should prevent the problem described in #956 (comment) ACKs for top commit: CaveSpectre11: utACK 74e7fc7 akshaynexus: utACK 74e7fc7 furszy: utACK [74e7fc7](74e7fc7) Warrows: Pretty straightforward indeed, utACK 74e7fc7 Tree-SHA512: bcb9752a689a058b6c33317136d16afd694b5da66c69cdd32a8b89b71059c5b2c5dc20c88045c52429fae99d45f508ea223f1b7d1afa5db3c77eb59befd48d51
Fuzzbawls
added
the
Needs Release Notes
Fuzzbawls
removed
the
Needs Release Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the calls to
CreateNewBlockWithKeywith PoS blocks, which are not needed.We simply call
CreateNewBlockwith an empy script for coinbase.It should prevent the problem described in #956 (comment)