[PoS] Stake Modifier V2 by random-zebra · Pull Request #983 · PIVX-Project/PIVX

random-zebra · 2019-08-14T14:58:06Z

This pull request defines a new 256-bit modifier for the proof of stake protocol, CBlockIndex::nStakeModifierV2.
It is computed at every block, by taking the hash of the modifier of previous block along with the coinstake input.
To meet the protocol, the PoS kernel must comprise the modifier of the previous block.

Enforcement height is set at 1214000 for testnet and 1967000 for mainnet.

This also includes upgrades to PROTOCOL_VERSION (to 70917) and to block version (to version 6) and disables 0-fee transactions.

CaveSpectre11

more in depth later; lunch break is over

Mrs-X · 2019-08-14T21:25:35Z

On a first view looks good, even when

    // switch with old modifier on upgrade block
    if (pindexPrev->nStakeModifierV2 == uint256() && pindexPrev->nStakeModifier)

(in my opinion) is unnecessary hard to verify/understand (you have to lookup those assumptions in chain.h) instead of simply using the block height of the upgrade block.

Warrows

Looks okay.

[Cleanup] Remove unused 'GetWeight()' function [Cleanup] Remove unneeded variables

also there's no need to count mints and spends here

other redundancies. [PoS][Refactor] CPivStake, caching data + removing redundant method calls. [PoS] Fix error in nSelectionIntervalStart integer division

…s nStakeMinAgeV2Modifier and nMaturityV2Modifier.

…y cycle of the CreateCoinStake loop.

require it to be nStakeMinDepth deep instead of nStkaMinAge old.

[SQUASH] Fix nTimeTx bug in Stake()

…of the loop.

the block under review. [PoS] CheckProofOfStake, stop searching a block on disk when it's absolutely not needed. * Not used variable nTargetTimespan in chainParams removed.

[SQUASH] Cleanup proof-of-stake debug log

…ersion.

[PoS] cleaning not used stakeTargetHit method + fixing bad nHeight in the new compute modifier method.

…ckIndex and not in the chainActive and look for it based on the next block hash and not based on height. * Contextual zPIV stake, invalid height contextual check, using tip instead of prev height + 1.

… the near future (4.0) and the code will be fully refactored soon. // This is just a quick inline towards that goal, the mempool by default will not accept them. Blocking // any subsequent network relay. [SQUASH] Permitting free txes only in regtest.

conditional log output in kernel.cpp functions can use the global fDebug variable instead of their own.

Also add help description for new keys

Fuzzbawls

ACK bf16514

Mrs-X

utACK bf16514

bf16514 [Consensus] New modifier enforcement height changed for mainnet (random-zebra) 6b6ef32 Don't load old stake modifier from disk after changeover height (Fuzzbawls) d085ed0 [Consensus] Fix old block version check (including v.6) (random-zebra) b1416f5 [Tests] fix blocks/maturity fakestake_accepted (random-zebra) c212587 [PoS] fix regtest nBlockStakeModifierlV2 and cbase maturity (random-zebra) dddca50 Use better JSON key names in block coinstake output (Fuzzbawls) 2835111 Don't shadow global fDebug (Fuzzbawls) 85fa96e [Consensus] New modifier enforcement height set. (furszy) a74f6cf [GUI] sendCoinsdialog, removing zero tx fee checkbox and label. (furszy) 6a33fff [Mempool] // As zero fee transactions are not going to be accepted in the near future (4.0) and the code will be fully refactored soon. // This is just a quick inline towards that goal, the mempool by default will not accept them. Blocking // any subsequent network relay. (furszy) 6c69cfe [PoS] * GetKernelStakeModifier, look for the next block in the mapBlockIndex and not in the chainActive and look for it based on the next block hash and not based on height. * Contextual zPIV stake, invalid height contextual check, using tip instead of prev height + 1. (furszy) d3db3e6 [PoS] Stake(): Add check for staked blocks in the future (random-zebra) f8777c6 [Refactor] Add future block time drift to chainparams (random-zebra) 8c7522b [PoS] Compute old modifier, invalid integer division removal plus extra logging for the stake modifier height added. (furszy) beaba47 [RPC] getblock, validate that PoS blocks to return the coin stake data. (furszy) 81446bb [PoS][RPC] getblock command, adding more information about the coin stake tx. (furszy) 820e08c [PoS][RPC][Refactor] GetHashProofOfStake and initStakeInput methods created, better method responsibility division from the CheckStakeKernelHash to be able to get the information for the getblock rpc command and possible future tests. (furszy) 4d5cc97 [Wallet] Staking, unreacheable code removed.. (furszy) 41ccf6b [PoS][Wallet] CreateCoinStake, if the block is from the future then start on a future time. (furszy) ffb0dd5 [Trivial] logging, removing none required jump lines. (furszy) 843dc56 [PoS] Allign ComputeStakeModifier (v2) to nHeight logic (random-zebra) 4c24934 [PoS] read/write block index modifier based on height and not block version. (furszy) 6297e77 [Core] Introduce Blocks version 6 (random-zebra) b8c59ae [PoS] CheckStakeKernelHash, was checking the previous block instead of the block under review. (furszy) 0d31ac2 [Wallet] HasMintableCoins, don't call GetAdjustedTime on every cycle of the loop. (furszy) d94931f [Trivial] Add logs to CheckKernelHash (random-zebra) eab9944 version bumped (furszy) 117f815 [PoS] New logic for stake input maturity (random-zebra) d805952 [Wallet] SelectStakeCoins using block time and fix GetBlocksToMaturity (random-zebra) 01ed69a [PoS] Remove extra nTime check in Stake() (random-zebra) 74d85c2 [Refactor][PoS] Do not calculate the prevBlock medianTimePast on every cycle of the CreateCoinStake loop. (furszy) a48a7a5 [Trivial] Compiler warning, uint_32 compared against int. (furszy) e9c07d0 [Consensus] V2 modifier protocol change, two new fields in chainparams nStakeMinAgeV2Modifier and nMaturityV2Modifier. (furszy) 3b97fc0 [PoS] Cleaning GetStakeModifierSelectionInterval() constant method + other redundancies. (furszy) 3c1fd7a [PoS] Stake Modifier V2 (random-zebra) f73a27f [Core] Do not check block if it's not the one needed (random-zebra) 1e4c864 [Cleanup] Clean error messages in CheckBlock (random-zebra) 401a986 [Consensus] Placeholder block height for modifier V2 enforcement (random-zebra) Pull request description: This pull request defines a new 256-bits modifier for the proof of stake protocol, `CBlockIndex::nStakeModifierV2`. It is computed at every block, by taking the hash of the modifier of previous block along with the coinstake input. To meet the protocol, the PoS kernel must comprise the modifier of the previous block. Enforcement height is set at 1214000 for testnet and 1967000 for mainnet. This also includes upgrades to `PROTOCOL_VERSION` (to 70917) and to block version (to version 6) and disables 0-fee transactions. ACKs for top commit: Fuzzbawls: ACK bf16514 Mrs-X: utACK bf16514 Tree-SHA512: 02fdcf1515b0b5571ef6c6eb9bf61429841e51b7372de50990bb4b58704030ebe9cc869ff896f507731cfa3f6a90ada25a4f71800f863dfc05b222368cafbbf0

Built on top of PIVX-Project#983, this adds the enforcement logic for 70917 and also updates the spork key.

… keys ce8dccb [Net] Protocol update enforcement for 70917 and new spork keys (Fuzzbawls) Pull request description: Built on top of #983, this adds the enforcement logic for 70917 and also updates the spork key. Top commit has no ACKs. Tree-SHA512: bde4ebea833acf746b838e354e8c5be55376ea4657e8b02874f958e6a43f4b5ae087051e7df0f76e455625558c56e7fb35bd9d01a3645b1dfc10bb14b48ad5ac

Warrows

ACK

[Consensus] Placeholder block height for modifier V2 enforcement

401a986

CaveSpectre11 reviewed Aug 14, 2019

View reviewed changes

Comment thread src/main.cpp Outdated

Comment thread src/main.cpp Outdated

Comment thread src/main.cpp Outdated

presstab reviewed Aug 14, 2019

View reviewed changes

Comment thread src/chain.h Outdated

Warrows reviewed Aug 15, 2019

View reviewed changes

CaveSpectre11 mentioned this pull request Aug 16, 2019

[RCP][Staking] Merge PIVX PRs UCCNetwork/ucc#38

Open

4 tasks

random-zebra force-pushed the 2019_new_stakeModifier branch 2 times, most recently from 215f3c4 to 6106e53 Compare August 17, 2019 01:31

furszy force-pushed the 2019_new_stakeModifier branch from 179090a to 0fb92a2 Compare August 23, 2019 21:33

furszy assigned furszy and random-zebra Aug 23, 2019

furszy added this to the 3.4.0 milestone Aug 23, 2019

Fuzzbawls force-pushed the 2019_new_stakeModifier branch from ad7a7f7 to 335b078 Compare August 24, 2019 09:54

random-zebra and others added 17 commits August 24, 2019 15:01

[Cleanup] Clean error messages in CheckBlock

1e4c864

[Cleanup] Remove unused 'GetWeight()' function [Cleanup] Remove unneeded variables

[Core] Do not check block if it's not the one needed

f73a27f

also there's no need to count mints and spends here

[PoS] Stake Modifier V2

3c1fd7a

[PoS] Cleaning GetStakeModifierSelectionInterval() constant method +

3b97fc0

other redundancies. [PoS][Refactor] CPivStake, caching data + removing redundant method calls. [PoS] Fix error in nSelectionIntervalStart integer division

[Consensus] V2 modifier protocol change, two new fields in chainparam…

e9c07d0

…s nStakeMinAgeV2Modifier and nMaturityV2Modifier.

[Trivial] Compiler warning, uint_32 compared against int.

a48a7a5

[Refactor][PoS] Do not calculate the prevBlock medianTimePast on ever…

74d85c2

…y cycle of the CreateCoinStake loop.

[PoS] Remove extra nTime check in Stake()

01ed69a

[Wallet] SelectStakeCoins using block time and fix GetBlocksToMaturity

d805952

[PoS] New logic for stake input maturity

117f815

require it to be nStakeMinDepth deep instead of nStkaMinAge old.

version bumped

eab9944

[Trivial] Add logs to CheckKernelHash

d94931f

[SQUASH] Fix nTimeTx bug in Stake()

[Wallet] HasMintableCoins, don't call GetAdjustedTime on every cycle …

0d31ac2

…of the loop.

[PoS] CheckStakeKernelHash, was checking the previous block instead of

b8c59ae

the block under review. [PoS] CheckProofOfStake, stop searching a block on disk when it's absolutely not needed. * Not used variable nTargetTimespan in chainParams removed.

[Core] Introduce Blocks version 6

6297e77

[SQUASH] Cleanup proof-of-stake debug log

[PoS] read/write block index modifier based on height and not block v…

4c24934

…ersion.

[PoS] Allign ComputeStakeModifier (v2) to nHeight logic

843dc56

[PoS] cleaning not used stakeTargetHit method + fixing bad nHeight in the new compute modifier method.

furszy and others added 8 commits August 24, 2019 15:19

[PoS] * GetKernelStakeModifier, look for the next block in the mapBlo…

6c69cfe

…ckIndex and not in the chainActive and look for it based on the next block hash and not based on height. * Contextual zPIV stake, invalid height contextual check, using tip instead of prev height + 1.

[GUI] sendCoinsdialog, removing zero tx fee checkbox and label.

a74f6cf

[Consensus] New modifier enforcement height set.

85fa96e

Don't shadow global fDebug

2835111

conditional log output in kernel.cpp functions can use the global fDebug variable instead of their own.

Use better JSON key names in block coinstake output

dddca50

Also add help description for new keys

[PoS] fix regtest nBlockStakeModifierlV2 and cbase maturity

c212587

[Tests] fix blocks/maturity fakestake_accepted

b1416f5

random-zebra force-pushed the 2019_new_stakeModifier branch from 335b078 to b1416f5 Compare August 25, 2019 10:15

random-zebra and others added 3 commits August 25, 2019 16:44

[Consensus] Fix old block version check (including v.6)

d085ed0

Don't load old stake modifier from disk after changeover height

6b6ef32

[Consensus] New modifier enforcement height changed for mainnet

bf16514

random-zebra changed the title ~~[WIP] - [PoS] Stake Modifier V2~~ [PoS] Stake Modifier V2 Aug 25, 2019

random-zebra added Block Generation Mining/Staking related issues Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes Protocol-Update Validation labels Aug 25, 2019

Fuzzbawls mentioned this pull request Aug 26, 2019

[Net] Protocol update enforcement for 70917 and new spork keys #987

Merged

Fuzzbawls approved these changes Aug 26, 2019

View reviewed changes

Mrs-X approved these changes Aug 26, 2019

View reviewed changes

Fuzzbawls merged commit bf16514 into PIVX-Project:master Aug 26, 2019

Fuzzbawls added a commit to Fuzzbawls/PIVX that referenced this pull request Aug 26, 2019

[Net] Protocol update enforcement for 70917 and new spork keys

ce8dccb

Built on top of PIVX-Project#983, this adds the enforcement logic for 70917 and also updates the spork key.

Warrows approved these changes Aug 26, 2019

View reviewed changes

JSKitty reviewed Sep 6, 2019

View reviewed changes

Comment thread src/kernel.cpp

Fuzzbawls removed the Needs Release Notes Placeholder tag for anything needing mention in the "Notable Changes" section of release notes label Dec 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PoS] Stake Modifier V2#983

[PoS] Stake Modifier V2#983
Fuzzbawls merged 38 commits into
PIVX-Project:masterfrom
random-zebra:2019_new_stakeModifier

random-zebra commented Aug 14, 2019 •

edited

Loading

Uh oh!

CaveSpectre11 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mrs-X commented Aug 14, 2019 •

edited

Loading

Uh oh!

Warrows left a comment

Uh oh!

Fuzzbawls left a comment

Uh oh!

Mrs-X left a comment

Uh oh!

Warrows left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

random-zebra commented Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CaveSpectre11 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mrs-X commented Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Warrows left a comment

Choose a reason for hiding this comment

Uh oh!

Fuzzbawls left a comment

Choose a reason for hiding this comment

Uh oh!

Mrs-X left a comment

Choose a reason for hiding this comment

Uh oh!

Warrows left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

random-zebra commented Aug 14, 2019 •

edited

Loading

Mrs-X commented Aug 14, 2019 •

edited

Loading