Many warnings during Orchestrator build

[mvousden]

The build process defined in the user documentation throws up a bunch of warnings when the Orchestrator is built on a POETS box. Here's a Gist containing the entire output of the build process: https://gist.github.com/mvousden/426805aa8d4ee171f90fa98a21aad02e

This was generated at commit 25a04c0, but the list of warnings is fairly consistent with current development.

We should remove these warnings, because they may identify pieces of functionality that are not working as intended.

[heliosfa]

I get 302 warnings (or there-abouts) when compiling from clean. This includes a rather ominous "integer overflow in expression" in Source/OrchBase/build_defs.cpp.

I have been through and partitoned up just the warnings per component in the attached doc/pdf
orch_warnings.docx
orch_warnings.pdf

[mvousden]

Woth noting that @heliosfa and myself have compiled with different GCC versions; my build was created using gcc 7.3.0 (from a POETS box).

[heliosfa]

A number of warnings have been corrected in #37 and #40. My count still lists 120 warnings as per attached
warnings.txt

[heliosfa]

Latest warnings: warnings.txt

We seem to be getting there! down to 93 when building on Fielding. I'm going to have a bash through a few.