Don't transform ampersands to dollars.#239
Merged
mvousden merged 1 commit into1.0.0-alphafrom Jun 15, 2021
Merged
Conversation
heliosfa
approved these changes
Jun 14, 2021
Contributor
heliosfa
left a comment
heliosfa
left a comment
There was a problem hiding this comment.
Assuming that there are no cases where there would be a dollar here, then this is all good!
Contributor
Author
Note the case on line 307 ;) |
Contributor
Ah, that was not shown in the github interface! All good then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't approve this, until @m8pple has tested it with his XML. I've tested with something I wrote myself, but I couldn't find a copy of the one he used.
Resolves #230.