Upgrade to PSPDFKit 5.0.1 for Android#37
Merged
davidschreiber merged 4 commits intomasterfrom Nov 27, 2018
Merged
Conversation
davidschreiber
added
update
blocked
anastasia-zaitsewa
previously approved these changes
Nov 15, 2018
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Tested and verified that we're running against the current nightly |
davidschreiber
force-pushed
the
davidschreiber/pspdfkit-5.0.1
branch
from
2373146 to
c336c09
Compare
davidschreiber
changed the title
davidschreiber
removed
the
blocked
tomassurin
approved these changes
Nov 26, 2018
Co-Authored-By: davidschreiber <davidschreiber@users.noreply.github.com>
simoarpe
approved these changes
Nov 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #35
This PR upgrades the Cordova wrapper to PSPDFKit 5.0.1 for Android.
Right now, the latest stable version 7.1.4 of
cordova-androidstill uses the outdated Android Gradle plugin 3.0.1, which is currently incompatible with this version of Cordova-Android. Since Cordova does not support forcing nightly builds using thepackage.jsonfile, customers have to manually upgrade to the nightly version from the command line (version8.0.0-nightly.2018.11.23.ef243418was tested and works perfectly fine). I documented to use this version in the basic setup steps of our README. However, if customers run into upgrade issues, we might need to put together a manual migration guide too (I'd leave that open for now).Changes in this PR