FEATURE: UnaryOperationNode !null
#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebaldi
requested changes
Apr 27, 2023
Member
grebaldi
left a comment
grebaldi
left a comment
There was a problem hiding this comment.
Hi @mhsdesign!
Thanks for adding the missing unary operation concept :)
There's one issue I noticed in how precedence is being treated, but that should be easily fixable.
test/Unit/Target/Php/Transpiler/UnaryOperation/UnaryOperationTranspilerTest.php
Outdated
Show resolved
Hide resolved
Contributor
Author
thanks for spotting this ;) Adjusted as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously
OPERATOR_BOOLEAN_NOTwas tokenized but dead code.todo: add type resolver