[Bug fix] Fixed the garbled text issues in Qwen3-8B #2737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lizexu123
changed the title
yuanlehome
reviewed
Jul 7, 2025
| else: | ||
| if self.tie_word_embeddings: | ||
| self.out_linear.weight.set_value( | ||
| get_tensor(state_dict.pop(self.linear_weight_key)).astype( |
yuanlehome
reviewed
Jul 7, 2025
Comment on lines
247
to
248
| prefix="lm_head", | ||
| ) |
yuanlehome
previously approved these changes
Jul 7, 2025
Jiang-Jia-Jun
previously approved these changes
Jul 8, 2025
qingqing01
reviewed
Jul 8, 2025
| embedding_dim=fd_config.model_config.hidden_size, | ||
| num_embeddings=fd_config.model_config.vocab_size, | ||
| prefix=(f"{fd_config.model_config.prefix_name}.embed_tokens"), | ||
| prefix="lm_head", |
Collaborator
There was a problem hiding this comment.
tie_word_embeddings True 或 False 时，prefix 这里都相同嘛？看起来 267行 True 的时候没用这个 prefix？
Collaborator
Author
There was a problem hiding this comment.
上一个commit是有区分的，远乐建议参考下ernie4_5_moe.py中的写法，应该是在下面set_state_dict下面，如果是权重共享，就把lm_head.out_linear的权重设置为embedding层的权重，本地测过qwen3-0.6b，精度正确
vivienfanghuagood
previously approved these changes
Jul 8, 2025
yuanlehome
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复了Qwen3-8b乱码问题， tie_word_embeddings一直为True的情况，考虑了tie_word_embeddings为False的情况，并且添加了权重lm_head.weight为列切的方式加载。修复后Qwen3-8b精度正确