Skip to content

Conversation

@kevincheng2
Copy link
Collaborator

@kevincheng2 kevincheng2 commented Nov 25, 2025

Motivation

将ds下发的mm_positions dict类型转换为ImagePosition 类型

Cherry-Pick from #5182

Modifications

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Nov 25, 2025

Thanks for your contribution!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where mm_positions received from the disaggregation scheduler (ds) is in dict format instead of ImagePosition objects. The fix adds conversion logic in Request.from_dict() to transform dict entries to ImagePosition instances.

Key Changes

  • Added type conversion for mm_positions from dict to ImagePosition objects in the deserialization process
  • Added error handling with traceback logging for conversion failures
  • Removed unused fastdeploy.envs import

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/online/20251131@a11d17c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/engine/request.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             release/online/20251131    #5220   +/-   ##
==========================================================
  Coverage                           ?   59.11%           
==========================================================
  Files                              ?      317           
  Lines                              ?    38688           
  Branches                           ?     5815           
==========================================================
  Hits                               ?    22871           
  Misses                             ?    13992           
  Partials                           ?     1825           
Flag Coverage Δ
GPU 59.11% <71.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jiang-Jia-Jun Jiang-Jia-Jun merged commit e0c7ebf into PaddlePaddle:release/online/20251131 Nov 25, 2025
18 of 20 checks passed
@kevincheng2 kevincheng2 deleted the cp_fix_ds_type branch January 19, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants