-
Notifications
You must be signed in to change notification settings - Fork 693
[BugFix][Cherry Pick] fix ds type bug #5220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix][Cherry Pick] fix ds type bug #5220
Conversation
|
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where mm_positions received from the disaggregation scheduler (ds) is in dict format instead of ImagePosition objects. The fix adds conversion logic in Request.from_dict() to transform dict entries to ImagePosition instances.
Key Changes
- Added type conversion for
mm_positionsfrom dict toImagePositionobjects in the deserialization process - Added error handling with traceback logging for conversion failures
- Removed unused
fastdeploy.envsimport
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/online/20251131 #5220 +/- ##
==========================================================
Coverage ? 59.11%
==========================================================
Files ? 317
Lines ? 38688
Branches ? 5815
==========================================================
Hits ? 22871
Misses ? 13992
Partials ? 1825
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e0c7ebf
into
PaddlePaddle:release/online/20251131
Motivation
将ds下发的mm_positions dict类型转换为ImagePosition 类型
Cherry-Pick from #5182
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.