Skip to content

[Cherry-Pick][CI][BugFix]Fix attention mask bug in D-Node of PD-split mode(#5245)#5246

Merged
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:release/online/20251131from
freeliuzc:release_fix_kernel_output
Nov 26, 2025
Merged

[Cherry-Pick][CI][BugFix]Fix attention mask bug in D-Node of PD-split mode(#5245)#5246
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:release/online/20251131from
freeliuzc:release_fix_kernel_output

Conversation

@freeliuzc
Copy link
Collaborator

@freeliuzc freeliuzc commented Nov 26, 2025

Motivation

  1. 在PD分离下,attn_mask_offset 会置为错误的值(比实际值大1)
  2. MTP 与 Target model 是类似的情况

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

  1. 当 Query 在 D节点第一次插入时,通过 rollback 回溯一步

#5245

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Nov 26, 2025

Thanks for your contribution!

@freeliuzc freeliuzc force-pushed the release_fix_kernel_output branch from 68b9fb6 to 890989d Compare November 26, 2025 07:41
Copy link
Collaborator

@carryyu carryyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/online/20251131@49be443). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/spec_decode/mtp.py 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##             release/online/20251131    #5246   +/-   ##
==========================================================
  Coverage                           ?   59.11%           
==========================================================
  Files                              ?      317           
  Lines                              ?    38690           
  Branches                           ?     5816           
==========================================================
  Hits                               ?    22872           
  Misses                             ?    13992           
  Partials                           ?     1826           
Flag Coverage Δ
GPU 59.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jiang-Jia-Jun Jiang-Jia-Jun merged commit bdcc952 into PaddlePaddle:release/online/20251131 Nov 26, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants