[Feature] Support async download chunk video features#5297
Merged
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:feature/experimental_feature_20250908from Dec 3, 2025
Merged
Conversation
|
Thanks for your contribution! |
Contributor
|
LGTM |
yangjianfengo1
approved these changes
Nov 28, 2025
kevincheng2
approved these changes
Nov 28, 2025
|
|
||
| def download_bos_features(bos_client, features_urls): | ||
| result_list = [] | ||
| for status, feature in download_from_bos(self.bos_client, features_urls): |
Collaborator
There was a problem hiding this comment.
使用这种写法感觉这个循环就没有意义了，这里原本想的是后边可以扩展多图并行下载和cache命中跳过部分图片的，0908分支先按这个写法吧，develop可以一起看下有没有更优雅的实现方式
Collaborator
Author
There was a problem hiding this comment.
这个encode分chunk应该不是最终优化版本，如果后续预处理重构实现，model_server这里就不需要接受分chunk的feature了，而是所有视频对应的唯一的embedding。这个问题可以有效解决。
Jiang-Jia-Jun
merged commit 5c2247c
into
PaddlePaddle:feature/experimental_feature_20250908
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
支持异步拉取视频chunk，兼容分/不分chunk，兼容图片、音频
Modifications
修改bos下载feature逻辑：
原bos链接：
link:[url1, url2, url3] 对应3个视频
新bos链接：
chunk link:[[url1, url2, url3], [url4], [url5]] 对应1个chunk视频和2个非chunk视频
non_chunk link :[[url1],[url2], [url3]] 对应3个非chunk视频