[BugFix] dynamic cache kv block_wise_fp8 not need create layer.cache_k_scale#5362
Merged
yuanlehome merged 1 commit intoPaddlePaddle:developfrom Dec 3, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
此 PR 修复了动态缓存 KV 使用 block_wise_fp8 量化时不必要地创建 scale 参数的 bug。当使用 block_wise_fp8 量化类型时,无需在 layer 中创建 cache_k_scale、cache_v_scale、cache_k_out_scale、cache_v_out_scale 以及零点参数。
- 将 scale 和 zero-point 参数创建逻辑包裹在条件判断中,仅在非 block_wise 量化类型时创建
- 保持与
process_loaded_weights方法中的条件判断逻辑一致
Sunny-bot1
approved these changes
Dec 3, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5362 +/- ##
==========================================
Coverage ? 59.33%
==========================================
Files ? 324
Lines ? 40057
Branches ? 6052
==========================================
Hits ? 23769
Misses ? 14401
Partials ? 1887
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your contribution! |
liyonghua0910
pushed a commit
to liyonghua0910/FastDeploy
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
动态cache kv的block_wise_fp8量化,不需要在layer里创建scale parameter
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.