[XPU] support XDNN downloading function#5365
Merged
zhupengyang merged 2 commits intoPaddlePaddle:developfrom Dec 5, 2025
Merged
[XPU] support XDNN downloading function#5365zhupengyang merged 2 commits intoPaddlePaddle:developfrom
zhupengyang merged 2 commits intoPaddlePaddle:developfrom
Conversation
cqulilujia
force-pushed
the
xdnn
branch
2 times, most recently
from
2718ca4 to
a2b3653
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5365 +/- ##
==========================================
Coverage ? 59.25%
==========================================
Files ? 325
Lines ? 40214
Branches ? 6087
==========================================
Hits ? 23828
Misses ? 14551
Partials ? 1835
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mayang002
reviewed
Dec 4, 2025
custom_ops/xpu_ops/setup_ops.py
Outdated
| XDNN_INC_PATH = os.path.join(XDNN_PATH, "include") | ||
| XDNN_LIB_DIR = os.path.join(XDNN_PATH, "so") | ||
| version_cmd = "python -c 'import paddle; paddle.version.show()' 2>&1 | grep xhpc | awk '{print $2}'" | ||
| XHPC_VERSION = subprocess.check_output(version_cmd, shell=True).strip().decode() |
There was a problem hiding this comment.
后续可以考虑对 subprocess.check_output 做个异常处理？如果 version_cmd 执行失败，给一个 paddle not found 之类的错误提示，对用户会更友好些
zhupengyang
reviewed
Dec 4, 2025
custom_ops/xpu_ops/setup_ops.py
Outdated
Comment on lines
125
to
156
| version_cmd = "python -c 'import paddle; paddle.version.show()' 2>&1 | grep xhpc | awk '{print $2}'" | ||
| XHPC_VERSION = subprocess.check_output(version_cmd, shell=True).strip().decode() |
Collaborator
There was a problem hiding this comment.
paddle.version.xpu_xhpc()
custom_ops/xpu_ops/setup_ops.py
Outdated
Comment on lines
137
to
168
| else: | ||
| download_and_extract(XHPC_URL, THIRD_PARTY_PATH) |
Collaborator
There was a problem hiding this comment.
这里打印warning log，显示本地xhpc版本和paddle xhpc版本，但是不要强制重新下载
- paddle使用本地xhpc编译的时候，从paddle.version.xhpc_xhpc()看到的版本可能和实际不同
- 会有需要强制使用本地xhpc的开发场景
Comment on lines
+139
to
+193
| else: | ||
| download_and_extract(XHPC_URL, THIRD_PARTY_PATH) |
Contributor
Author
There was a problem hiding this comment.
download_and_extract函数中会打印
cqulilujia
force-pushed
the
xdnn
branch
3 times, most recently
from
6b25695 to
12c38f6
Compare
|
Thanks for your contribution! |
mayang002
approved these changes
Dec 5, 2025
hong19860320
approved these changes
Dec 5, 2025
Collaborator
hong19860320
left a comment
hong19860320
left a comment
There was a problem hiding this comment.
LGTM，按照讨论的结果，后续再提一个 PR 保证优先使用 paddle 中的 xdnn.h，仅 plugin 编译所需的 kernel 头文件才在下载的xhpc 包中搜索。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
增加编译时的XDNN下载逻辑