Skip to content

[Intel HPU] fix bug about RP 5138#5380

Merged
zoooo0820 merged 1 commit intoPaddlePaddle:developfrom
fmiao2372:develop_hpu_fixbug
Dec 5, 2025
Merged

[Intel HPU] fix bug about RP 5138#5380
zoooo0820 merged 1 commit intoPaddlePaddle:developfrom
fmiao2372:develop_hpu_fixbug

Conversation

@fmiao2372
Copy link
Contributor

Motivation

#5138 breaks hpu function, fixed it

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

hpu_model_runner.py

Usage or Command

no command usage change

Accuracy Tests

no impact on accuracy

Checklist

  • [Done] Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • [Done] Format your code, run pre-commit before commit.
  • [Done] Add unit tests. Please write the reason in this PR if no unit tests.
    conducted by local tests
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

Copilot AI review requested due to automatic review settings December 5, 2025 01:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes compatibility issues in the HPU (Intel Habana Processing Unit) model runner introduced by PR #5138. The changes update the fused_mlp_forward function signature to match the expected interface with proper parameter naming and type annotations.

Key Changes:

  • Added missing ForwardMeta import
  • Updated fused_mlp_forward function signature to accept hidden_states and forward_meta parameters instead of generic x

hidden_states: paddle.Tensor,
forward_meta: Optional[ForwardMeta] = None,
):
""" """
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty docstring should be removed or replaced with a meaningful description of the function's purpose, parameters, and return value.

Suggested change
""" """
"""
The forward function for the MLP (Multi-Layer Perceptron) layer.
Args:
hidden_states (paddle.Tensor): The input tensor to the MLP layer.
forward_meta (Optional[ForwardMeta]): Optional metadata for the forward pass.
Returns:
paddle.Tensor: The output tensor after applying the MLP layer and (optionally) all-reduce.
"""

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@620d1da). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5380   +/-   ##
==========================================
  Coverage           ?   59.25%           
==========================================
  Files              ?      325           
  Lines              ?    40216           
  Branches           ?     6087           
==========================================
  Hits               ?    23828           
  Misses             ?    14552           
  Partials           ?     1836           
Flag Coverage Δ
GPU 59.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@zoooo0820 zoooo0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoooo0820 zoooo0820 merged commit ebe613c into PaddlePaddle:develop Dec 5, 2025
14 of 18 checks passed
@paddle-bot
Copy link

paddle-bot bot commented Dec 5, 2025

Thanks for your contribution!

@paddle-bot paddle-bot bot added the contributor External developers label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants