Skip to content

[BugFix] Fix the issue of redundant logging for certain events in the trace_logger#5386

Merged
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:developfrom
qwes5s5:fix_trace_log
Dec 5, 2025
Merged

[BugFix] Fix the issue of redundant logging for certain events in the trace_logger#5386
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:developfrom
qwes5s5:fix_trace_log

Conversation

@qwes5s5
Copy link
Collaborator

@qwes5s5 qwes5s5 commented Dec 5, 2025

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

We have currently identified an issue in the trace_logger logs where a single request is redundantly logging the following three events: RESOURCE_ALLOCATE_END, REQUEST_SCHEDULE_END, and INFERENCE_START. Further investigation revealed that this is caused by the function _schedule_request_to_worker_v1 logging the timestamps repeatedly after the ENABLE_V1_KVCACHE_SCHEDULER feature was enabled.

Modifications

Added a conditional check before logging events in the _schedule_request_to_worker_v1 method, ensuring events are only logged when the current task type is PREFILL.

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@qwes5s5 qwes5s5 changed the title [BugFix] Fixed the issue of redundant logging for certain events in the trace_logger [BugFix] Fix the issue of redundant logging for certain events in the trace_logger Dec 5, 2025
@qwes5s5 qwes5s5 requested a review from Jiang-Jia-Jun December 5, 2025 04:00
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@9460254). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/engine/common_engine.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5386   +/-   ##
==========================================
  Coverage           ?   59.25%           
==========================================
  Files              ?      325           
  Lines              ?    40221           
  Branches           ?     6090           
==========================================
  Hits               ?    23832           
  Misses             ?    14553           
  Partials           ?     1836           
Flag Coverage Δ
GPU 59.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jiang-Jia-Jun Jiang-Jia-Jun merged commit 1aefbef into PaddlePaddle:develop Dec 5, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants