[BugFix] Fix the issue of redundant logging for certain events in the trace_logger#5386
Merged
Jiang-Jia-Jun merged 1 commit intoPaddlePaddle:developfrom Dec 5, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5386 +/- ##
==========================================
Coverage ? 59.25%
==========================================
Files ? 325
Lines ? 40221
Branches ? 6090
==========================================
Hits ? 23832
Misses ? 14553
Partials ? 1836
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jiang-Jia-Jun
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have currently identified an issue in the trace_logger logs where a single request is redundantly logging the following three events: RESOURCE_ALLOCATE_END, REQUEST_SCHEDULE_END, and INFERENCE_START. Further investigation revealed that this is caused by the function _schedule_request_to_worker_v1 logging the timestamps repeatedly after the ENABLE_V1_KVCACHE_SCHEDULER feature was enabled.
Modifications
Added a conditional check before logging events in the _schedule_request_to_worker_v1 method, ensuring events are only logged when the current task type is PREFILL.
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.