[BugFix] Fix limit_thinking early return logic in CUDA kernels #5471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick fix from PR #5469. The limit_thinking kernels incorrectly used AND (
&&) logic for early return conditions, requiring bothcurrent_limit_think_statusmatch ANDstop_flags[bid]to be true. This prevented proper early return when only one condition was met.Modifications
Changed condition logic from AND to OR in 4 CUDA kernel files:
custom_ops/gpu_ops/limit_thinking_content_length_v1.cucustom_ops/gpu_ops/limit_thinking_content_length_v2.cucustom_ops/gpu_ops/speculate_decoding/speculate_limit_thinking_content_length_v1.cucustom_ops/gpu_ops/speculate_decoding/speculate_limit_thinking_content_length_v2.cuBefore:
After:
Updated Chinese comments from "且" (AND) to "或者" (OR) to match corrected logic.
Usage or Command
No API changes. Bug fix only affects internal kernel behavior.
Accuracy Tests
No unit tests added - cherry-pick of verified fix from #5469.
Checklist
pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.