Skip to content

[XPU] fix mtp multi batch#5521

Merged
cmcamdy merged 1 commit intoPaddlePaddle:developfrom
cmcamdy:fix_mtp_multi_batch2
Dec 12, 2025
Merged

[XPU] fix mtp multi batch#5521
cmcamdy merged 1 commit intoPaddlePaddle:developfrom
cmcamdy:fix_mtp_multi_batch2

Conversation

@cmcamdy
Copy link
Collaborator

@cmcamdy cmcamdy commented Dec 12, 2025

Motivation

跑XPU MTP集中式 benchmark时发现draft命中率偏低,且随着batch增大而降低,该现象最终定位在draft model的cache没有正确初始化,初始化完成后,跑benchmark得到的draft model接受率恢复正常

  • 分析最终原因应当是profile时期初始化的cache 太小了,后续base model会在update_share_input_block_num中更新最终的cache空间,draft此处未更新,导致draft model跑多batch的时候block table中的值越界了(V1 base和draft使用一套block table)

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

修复前
image

修复后
image

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Dec 12, 2025

Thanks for your contribution!

Copy link
Collaborator

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@3c1f7b8). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5521   +/-   ##
==========================================
  Coverage           ?   60.42%           
==========================================
  Files              ?      329           
  Lines              ?    41088           
  Branches           ?     6262           
==========================================
  Hits               ?    24826           
  Misses             ?    14373           
  Partials           ?     1889           
Flag Coverage Δ
GPU 60.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmcamdy cmcamdy merged commit 6cc3cb4 into PaddlePaddle:develop Dec 12, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants