Skip to content

Conversation

@liyonghua0910
Copy link
Collaborator

@liyonghua0910 liyonghua0910 commented Dec 12, 2025

Motivation

对于 EP 模型,清除权重后的下一次权重更新,会直接执行一次 event_loop_normal 后半段的 execute_model,而此时 weight/cache 都还没有重建,导致执行出错。

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

在权重清除/更新后,让 worker 跳过后半段的执行,回到 event_loop_normal 的开头,重新读取状态信号。此项改动对于权重清除场景是必要的,对于权重更新场景也是无害的。

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Dec 12, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/2.4@4e5e36e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/worker/worker_process.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release/2.4    #5523   +/-   ##
==============================================
  Coverage               ?   58.94%           
==============================================
  Files                  ?      327           
  Lines                  ?    40626           
  Branches               ?     6174           
==============================================
  Hits                   ?    23949           
  Misses                 ?    14819           
  Partials               ?     1858           
Flag Coverage Δ
GPU 58.94% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liyonghua0910 liyonghua0910 changed the title [fix] fix ep loop [BugFix] [RL] skip model executing after clearing/updating is done (#5527) Dec 12, 2025
@liyonghua0910 liyonghua0910 changed the title [BugFix] [RL] skip model executing after clearing/updating is done (#5527) [Cherry-Pick] [BugFix] [RL] skip model executing after clearing/updating is done (#5527) Dec 12, 2025
@Jiang-Jia-Jun Jiang-Jia-Jun merged commit 12e0206 into PaddlePaddle:release/2.4 Dec 12, 2025
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants