[Models] Add forward_meta to VocabParallelEmbedding of all models#5524
Merged
SigureMo merged 1 commit intoPaddlePaddle:developfrom Dec 12, 2025
Merged
[Models] Add forward_meta to VocabParallelEmbedding of all models#5524SigureMo merged 1 commit intoPaddlePaddle:developfrom
SigureMo merged 1 commit intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5524 +/- ##
==========================================
Coverage ? 60.34%
==========================================
Files ? 329
Lines ? 41089
Branches ? 6262
==========================================
Hits ? 24794
Misses ? 14404
Partials ? 1891
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SigureMo
approved these changes
Dec 12, 2025
| param[:, shard_weight.shape[1] :].fill_(0) | ||
|
|
||
| def forward(self, ids_remove_padding, forward_meta=None) -> paddle.Tensor: | ||
| def forward(self, ids_remove_padding: paddle.Tensor = None, forward_meta: ForwardMeta = None) -> paddle.Tensor: |
Member
There was a problem hiding this comment.
Suggested change
| def forward(self, ids_remove_padding: paddle.Tensor = None, forward_meta: ForwardMeta = None) -> paddle.Tensor: | |
| def forward(self, ids_remove_padding: Optional[paddle.Tensor] = None, forward_meta: Optional[ForwardMeta] = None) -> paddle.Tensor: |
| def get_input_embeddings(self, ids_remove_padding: paddle.Tensor) -> paddle.Tensor: | ||
| return self.embed_tokens(ids_remove_padding=ids_remove_padding) | ||
| def get_input_embeddings( | ||
| self, ids_remove_padding: paddle.Tensor, forward_meta: ForwardMeta = None |
Member
There was a problem hiding this comment.
同上，如果默认值都是 None 了，类型里不应该没有 None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
同 #5495 ，透传 forward_meta 参数
Modifications
透传 forward_meta 参数
Usage or Command
NO NEED
Accuracy Tests
NO NEED
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.