[CI][XPU] add mtp case#5537
Conversation
|
Thanks for your contribution! |
tests/xpu_ci/test_mtp.py
Outdated
| import openai | ||
| import pytest | ||
| from conftest import get_model_path, get_port_num, print_logs_on_failure, start_server | ||
| import json |
There was a problem hiding this comment.
导入语句的顺序不符合Python最佳实践。json标准库导入应该放在第三方库(openai, pytest)之前,conftest本地导入应该最后。建议按照以下顺序组织导入:
- 标准库(json)
- 第三方库(openai, pytest)
- 本地模块(conftest)
| import openai | |
| import pytest | |
| from conftest import get_model_path, get_port_num, print_logs_on_failure, start_server | |
| import json | |
| import json | |
| import openai | |
| import pytest | |
| from conftest import get_model_path, get_port_num, print_logs_on_failure, start_server |
| "--quantization", | ||
| "wint4", | ||
| "--speculative-config", | ||
| f"{json.dumps(spec_config)}", |
There was a problem hiding this comment.
f-string格式化字符串中不需要额外的花括号。应该直接使用 json.dumps(spec_config) 而不是 f"{json.dumps(spec_config)}",因为json.dumps已经返回字符串类型。
| f"{json.dumps(spec_config)}", | |
| json.dumps(spec_config), |
Removed duplicate import of json and simplified spec_config formatting.
|
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5537 +/- ##
==========================================
Coverage ? 60.74%
==========================================
Files ? 329
Lines ? 41140
Branches ? 6271
==========================================
Hits ? 24991
Misses ? 14258
Partials ? 1891
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.