Skip to content

[Others] Clean code#5543

Merged
zhoutianzi666 merged 4 commits intoPaddlePaddle:developfrom
zhoutianzi666:clean_code
Dec 15, 2025
Merged

[Others] Clean code#5543
zhoutianzi666 merged 4 commits intoPaddlePaddle:developfrom
zhoutianzi666:clean_code

Conversation

@zhoutianzi666
Copy link
Collaborator

@zhoutianzi666 zhoutianzi666 commented Dec 14, 2025

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

修改几个看着很难受的代码

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Dec 14, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@d01cb27). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/worker/worker_process.py 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5543   +/-   ##
==========================================
  Coverage           ?   60.73%           
==========================================
  Files              ?      329           
  Lines              ?    41135           
  Branches           ?     6270           
==========================================
  Hits               ?    24982           
  Misses             ?    14263           
  Partials           ?     1890           
Flag Coverage Δ
GPU 60.73% <57.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhoutianzi666 zhoutianzi666 changed the title Clean code [Others] Clean code Dec 14, 2025
@zhoutianzi666 zhoutianzi666 force-pushed the clean_code branch 2 times, most recently from e2b77d4 to 58fc7d7 Compare December 14, 2025 12:28
@zhoutianzi666 zhoutianzi666 merged commit 722de5a into PaddlePaddle:develop Dec 15, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants