Skip to content

Conversation

@Deleter-D
Copy link
Collaborator

Motivation

💡 If this PR is a Cherry Pick, the PR title needs to follow the format by adding the [Cherry-Pick] label at the very beginning and appending the original PR ID at the end. For example, [Cherry-Pick][CI] Add check trigger and logic(#5191)

💡 如若此PR是Cherry Pick,PR标题需遵循格式,在最开始加上[Cherry-Pick]标签,以及最后面加上原PR ID,例如[Cherry-Pick][CI] Add check trigger and logic(#5191)

Modifications

  • Support GLM MTP
  • Implement neox_partial_rope for the speculative decoding branch

Usage or Command

Accuracy Tests

Checklist

  • Add at least a tag in the PR title.
    • Tag list: [[FDConfig],[APIServer],[Engine], [Scheduler], [PD Disaggregation], [Executor], [Graph Optimization], [Speculative Decoding], [RL], [Models], [Quantization], [Loader], [OP], [KVCache], [DataProcessor], [BugFix], [Docs], [CI], [Optimization], [Feature], [Benchmark], [Others], [XPU], [HPU], [GCU], [DCU], [Iluvatar], [Metax]]
    • You can add new tags based on the PR content, but the semantics must be clear.
  • Format your code, run pre-commit before commit.
  • Add unit tests. Please write the reason in this PR if no unit tests.
  • Provide accuracy results.
  • If the current PR is submitting to the release branch, make sure the PR has been submitted to the develop branch, then cherry-pick it to the release branch with the [Cherry-Pick] PR tag.

@paddle-bot
Copy link

paddle-bot bot commented Jan 15, 2026

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 38.16794% with 81 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@1aa7e82). Learn more about missing BASE report.

Files with missing lines Patch % Lines
fastdeploy/model_executor/models/glm4_mtp.py 37.09% 78 Missing ⚠️
fastdeploy/model_executor/utils.py 33.33% 1 Missing and 1 partial ⚠️
fastdeploy/spec_decode/mtp.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6047   +/-   ##
==========================================
  Coverage           ?   66.51%           
==========================================
  Files              ?      350           
  Lines              ?    45183           
  Branches           ?     6947           
==========================================
  Hits               ?    30054           
  Misses             ?    12912           
  Partials           ?     2217           
Flag Coverage Δ
GPU 66.51% <38.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@EmmonsCurse EmmonsCurse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for coverage~

@Deleter-D Deleter-D merged commit bda38aa into PaddlePaddle:develop Jan 16, 2026
25 of 32 checks passed
@Deleter-D Deleter-D deleted the dev_glm_mtp branch January 19, 2026 10:19
LLSGYN pushed a commit to LLSGYN/FastDeploy that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants