Implement support for <assert-xml file=".."/> for XSLT tests#119
Merged
faassen merged 1 commit intoPaligo:mainfrom Aug 28, 2025
Merged
Implement support for <assert-xml file=".."/> for XSLT tests#119faassen merged 1 commit intoPaligo:mainfrom
faassen merged 1 commit intoPaligo:mainfrom
Conversation
fefab3f to
f7ea0bf
Compare
Collaborator
|
I wouldn't know where the right way is off the top of my head, but since it runs more tests successfully I'm taking it. It's not like the way we run the tests is the most important part of the codebase, as long as we can run them correctly. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ends up fixing 54 tests across the board; out of a total of 537 tests that use
<assert-xml file=".."/>.Not convinced that's quite the place or way to implement the feature; just getting my feet wet for now 😅
I experimented with making a new
AssertXmlFilestruct which has a reimplementation ofAssertXml::assert_value, but that causes more code duplication overall. I also played around with makingassert_xml_queryread the file directly, but then I cannot return aTestOutcome::EnvironmentErroras easily. I also considered makingAssertXml::MatchFile(...)hold a relative path and not an absolute path to the needed file, however getting the path to the testcases fromassert_valueis hard, given its current signature.