Skip to content

Implement support for <assert-xml file=".."/> for XSLT tests#119

Merged
faassen merged 1 commit intoPaligo:mainfrom
bojidar-bg:x-assertxml-file
Aug 28, 2025
Merged

Implement support for <assert-xml file=".."/> for XSLT tests#119
faassen merged 1 commit intoPaligo:mainfrom
bojidar-bg:x-assertxml-file

Conversation

@bojidar-bg
Copy link
Contributor

This ends up fixing 54 tests across the board; out of a total of 537 tests that use <assert-xml file=".."/>.

Not convinced that's quite the place or way to implement the feature; just getting my feet wet for now 😅
I experimented with making a new AssertXmlFile struct which has a reimplementation of AssertXml::assert_value, but that causes more code duplication overall. I also played around with making assert_xml_query read the file directly, but then I cannot return a TestOutcome::EnvironmentError as easily. I also considered making AssertXml::MatchFile(...) hold a relative path and not an absolute path to the needed file, however getting the path to the testcases from assert_value is hard, given its current signature.

@faassen
Copy link
Collaborator

faassen commented Aug 28, 2025

I wouldn't know where the right way is off the top of my head, but since it runs more tests successfully I'm taking it. It's not like the way we run the tests is the most important part of the codebase, as long as we can run them correctly.

@faassen faassen merged commit af220a3 into Paligo:main Aug 28, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants