Add tracking for various unsupported features and implement xsl:output as the one failing the most tests#124
Merged
faassen merged 4 commits intoPaligo:mainfrom Oct 10, 2025
Merged
Conversation
a466c2c to
9791311
Compare
9791311 to
b8e6058
Compare
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the relatively low counts of fixed tests by #123, I decided to approach the problem a bit more systematically, and find which parts of the code throw the most Unsupported errors throughout. This was done in the first two commits. (First commit should have been part of #118 probably, but apparently I missed updating the filters back then.)
At that point, I could use the following Bash pipeline to determine the most-common sources of errors in the test suite:
Output at that point:
As most errors seemed to come from the lack of
xsl:outputsupport (and most tests that use that just have a basicxsl:output method="xml" encoding="UTF-8" />or so at the start), I decided to follow up on that and implementxsl:output.Now, the output from the pipeline above looks like the following:
So, with this implemented, working through swathes of tests in #123 makes more sense (: