-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Test Case Enhancements WIP #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs update with main, failing application counts total test
|
|
||
| const revisionResult = await testApplicationService.createRevisionRequest({ | ||
| applicationId: testId, | ||
| revisionData: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use the existing revision request mock in application-controller? More reason to move it to mocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also used in requestApplicationRevisionsByInstitutionalRep test
Summary
Various test-case updates
Description of Changes
- Added
getFirstApplicationTestByStatefunction in controller to reduce redundant testsshould fetch revisions for a valid applicationId where revisions existtestshould be able to create revisions DAC request when application is in DAC_REVIEW statetestshould fail revisions DAC request if application is not in the correct statetestReadiness Checklist
#{TicketNumber}: Description of Changesapi,ui,data-model, etc.)feature,fix,chore,documentation).env.schemafile and documented in the README