Skip to content

impose EqualsAvoidsNull#1

Merged
Pankraz76 merged 54 commits intomainfrom
replace-checkstyle-with-rewrite
Jul 11, 2025
Merged

impose EqualsAvoidsNull#1
Pankraz76 merged 54 commits intomainfrom
replace-checkstyle-with-rewrite

Conversation

@Pankraz76
Copy link
Copy Markdown
Owner

Describe the PR

Related issues

  • Fix #

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

Vincent Potucek added 30 commits June 30, 2025 13:16
@Pankraz76 Pankraz76 marked this pull request as ready for review July 11, 2025 11:32
Comment thread pom.xml
<exclusion>**Jep441_PatternMatchingForSwitch.java</exclusion>
<exclusion>**testdata**</exclusion>
</exclusions>
<activeRecipes>
Copy link
Copy Markdown
Owner Author

@Pankraz76 Pankraz76 Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<activeRecipes>
<recipes>

@timtebeek

is there a way we can overload the API, to have the same look and feel in the exclusions-exclusion division?
going from activeRecipes-recipes to recipes-recipes

for having more concise/compact API, as the rewrite context is kind of clear.

Comment thread pom.xml
<!-- <recipe>org.openrewrite.text.EndOfLineAtEndOfFile</recipe>-->
</activeRecipes>
<failOnDryRunResults>true</failOnDryRunResults>
<rewriteSkip>${rewrite.skip}</rewriteSkip>
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<rewriteSkip>${rewrite.skip}</rewriteSkip>
<skip>${rewrite.skip}</skip>

@Pankraz76 Pankraz76 merged commit e4f23a0 into main Jul 11, 2025
14 of 16 checks passed
@Pankraz76 Pankraz76 changed the title Replace checkstyle with rewrite impose EqualsAvoidsNull Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant