Conversation
Introduces a configurable option to set custom timestamp formats in log messages, enhancing versatility for log management. Updates configuration files and tests to accommodate this feature. Modifies logger functions to handle custom time formats and improves test coverage to ensure correct functionality.
Revises logger initialization to use consistent timestamp formats across tests. Updates regex patterns to reflect the new formats. Ensures log message verification aligns with changed timestamp patterns. This aims to improve test clarity and reduce format-related errors.
tinhtruong
approved these changes
Sep 17, 2025
hiroxy
reviewed
Sep 19, 2025
hiroxy
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By request from @tinhtruong I have made an alternative to "LogFileTimestampMicroseconds" and instead introduced a "LogFileTimestampFormat" giving the customers complete control of the format.