Plugin chat prompts are no longer being cancelled from being visible in chat

[Sikatsu]

Expected behavior

When a plugin asks me to type a value within the chat, the message should be cancelled from being visible to everyone.

Observed/Actual behavior

The messages are no longer being cancelled and are visible to every player on the server.

Steps/models to reproduce

You can try this with many different plugins, as they are all broken in this regard:

• Auction house
• DisplayShops
• HyperDrive
• HeadDatabase
• PremiumVanish/SuperVanish
• etc

The issue is there after updating from paper build 399 to 420.
I have tested this on my survival, creative AND nearly empty test server with just HDB and the two different paper builds.

Plugin and Datapack List

Plugins (28): AntiPopup, ArmorStandEditor, ArtMap, CMI, CMILib, ChatControlRed, CommandPanels, CoreProtect, ExecuteEverywhere, HeadDatabase, LuckPerms, Multiverse-Core, MyCommand, PlaceholderAPI, PlayerParticles, PlotSquared, PremiumVanish, ProtocolLib, ServerUtils, ShowItem, SupremeTags, TAB-Bridge, VCLink2-Bukkit, Vault, VillagerCraftCore, WorldEdit, WorldGuard and eGlow

Paper version

[11:15:16 INFO]: This server is running Paper version git-Paper-420 (MC: 1.19.3) (Implementing API version 1.19.3-R0.1-SNAPSHOT) (Git: 81d7ff6)
You are running the latest version

Other

[electronicboy]

Hard to say around premium/closed source plugins, given that the only real change has been in the plugin loader, this would generally scream more towards a plugin issue, primarily around their dependency on event order;

[Sikatsu]

I see. Wouldn't it be suspicious this happens to all plugins though? None of the ones I mentioned are open source?

For now i'll stay on the old version.

[electronicboy]

The only open source plugin is HyperDrive, which does appear to be handling it properly, so it not working would be suspicious, but, nothing has changed with the event that it uses in a long time, so that would make 0 sense, would need somebody to reproduce

Outside of that, we'd need somebody to reproduce this, or a minimal reproduction case, etc; Theres no strong leads here outside of the fact that we just recently changed a system which between plugin devs and spigot was screwed

[Akiranya]

Do you run the server behind a proxy? if so, did you update the proxy/make any changes on the proxy as well before this issue?

My guess is that if some plugins on the proxy were intercepting the messages sent from players and then broadcast it to the backend server, then the message would actually bypass any check done by any plugins installed on Paper.

Take a look at this piece of information: https://william278.net/docs/huskchat/backend-chat-entry

Hope that helps

[Sikatsu]

It indeed runs behind a waterfall proxy. Though nothing was changed or updated on that regard. All that I have actually changed is the paper version on the backend servers.

I'll take a look at the website you provided.

[Sikatsu]

Would installing HuskChat also solve my issue?

On a clean bungee installation with 2 backend servers, running waterfall and paper with vault, luckperms and hyperdrive I am able to reproduce this issue unless I rollback my paper version to an older build.

[electronicboy]

Would need to isolate what build broke it, as that makes zero sense to me

…

On Wed, 1 Mar 2023, 21:40 Sikatsu, ***@***.***> wrote: Would installing HuskChat also solve my issue? On a clean bungee installation with 2 backend servers, running waterfall and paper with vault, luckperms and hyperdrive I am able to reproduce this issue unless I rollback my paper version to an older build. — Reply to this email directly, view it on GitHub <#8911 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAZBOJNRQVPEG4VFVOXDWZ665XANCNFSM6AAAAAAVGW4OTE> . You are receiving this because you commented.Message ID: ***@***.***>

[Sikatsu]

Not sure which build exactly, but between 399 and 420. I could try to pinpoint it exactly, but unnfortunately that has to be for monday as i'm out for a few days.

[Sikatsu]

@electronicboy I can confirm that build 404 still works, it breaks on build 405 for ALL plugins that work with a chat prompt.

With this commit: #8108

[Omarlatif]

I can confirm that on my server it also breaks on build 405.

[MiniDigger]

does somebody have code to repro? I am having a hard time trying to understand what you mean by prompts, is it the conversation api that is broken? or just plugins cancelling one of the chat events?

[Sikatsu]

For example in headdatabase there is a button in the GUI ''Search heads..'', when I click on it, a title comes up to enter a value within the chat. When I do that however, the value is visible to everyone on the server, rather then being cancelled.

Any plugin that makes use of chat prompts (enter a value in chat, like prices etc) is broken as of build 405.

Don't really have any code myself to reproduce, as I am not a developer unfortunately.