Fix MC-125757

[BillyGalbreath]

This forces the despawn counter to start ticking regardless of
state after the arrow has been alive for 200 ticks (10 seconds)
instead of getting stuck in a never despawn state (bubble columns,
etc).

https://bugs.mojang.com/browse/MC-125757

[Prof-Bloodstone]

(minor) 20 ticks == 1 second. Should be 200 ticks :)
EDIT: You were a second quicker lol

[BillyGalbreath]

(minor) 20 ticks == 1 second. Should be 200 ticks :)

Tried to get that typo fix in before anyone could comment :P

[Phoenix616]

This really should have a config option which allows one to restore the normal behavior as this is a breaking mechanic change for some redstone maps using the despawning as a timer (e.g. with arrows falling through cobweb)

[BillyGalbreath]

phoenix, maybe I don't understand what you mean.

The pr doesn't make arrows despawn in 10 seconds. It starts their natural despawn counter after 10 seconds. Natural despawn for arrows is 5 minutes, iirc, so these "cobweb timers" still have 5 minutes (plus 10 seconds) to work..

What this fixes is the cases where arrows literally get stuck in a state where the despawn counter never starts counting. Bubble columns, being the most notable scenario.

If a server requires more than 5 minutes of arrow life, they already have that option to set a higher despawn time.

[Phoenix616]

Apparently arrow cobweb timers aren't a thing (anymore? I swear they were in the past) so I guess this doesn't hurt too much beyond some TNT-Arrow-cannons

[lerokko]

Apparently arrow cobweb timers aren't a thing (anymore? I swear they were in the past) so I guess this doesn't hurt too much beyond some TNT-Arrow-cannons

Just out of curiosity, would dropper+item+cobweb timer be different? Because until now you could have them be delayed more than 5 minutes? Or would they provide a sufficient alternative?

[Phoenix616]

@lerokko This patch only affects shot arrows, no other entity.

[Decme]

Need this for Llama spit too.