[WIP] New Plugin Life-cycle API #4319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
requested changes
Oct 5, 2020
Spigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated
Show resolved
Hide resolved
Spigot-API-Patches/0229-Add-Server-isStarting-Bukkit-isStarting-API.patch
Outdated
Show resolved
Hide resolved
Proximyst
suggested changes
Nov 14, 2020
Comment on lines
+21
to
+27
| + * <li>Reloads all configs | ||
| + * <li>Reloads server icon | ||
| + * <li>Reloads ban lists | ||
| + * <li>Reloads all plugins that which both their dependencies and themselves meet one the following: | ||
| + * <ul> | ||
| + * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#ALWAYS ALWAYS} reload policy. | ||
| + * <li>Have the {@link org.bukkit.plugin.PluginReloadPolicy#SAME_HASH SAME_HASH} reload policy and the plugin's file is unmodified from startup. |
| + */ | ||
| + public static PluginReloadPolicy getByName(@NotNull String name) { | ||
| + try { | ||
| + return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_")); |
Contributor
There was a problem hiding this comment.
Suggested change
| + return valueOf(name.toUpperCase(Locale.ENGLISH).replaceAll("[^A-Z-]", "").replace("-", "_")); | |
| + return valueOf(name.toUpperCase(Locale.ENGLISH).replace("-", "_")); |
Don't correct the user; them entering e.g. 123 is not grounds for Paper to care as that's their fault. The replacing - -> _ is however alright as that's a very easy thing to fuck up (cough Bungee & depend/-s...).
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue. |
Member
Author
|
being continued by @Owen1212055 in #8108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP PR for the new plugin life-cycle API.
See #4317 for a better description