Conversation
Codebook uses toLowerCase for fully upper-cased type names like UUID. The call uses the default locale, which might incorrectly map characters like 'I' to lowercase versions that are not 'i'. This prevents further patching of the mache sources. Correctly specify the ROOT locale instead, making the logic independent from the JVM default locale.
kennytv
approved these changes
May 11, 2025
Owen1212055
approved these changes
May 11, 2025
MiniDigger
approved these changes
May 11, 2025
Member
MiniDigger
left a comment
MiniDigger
left a comment
There was a problem hiding this comment.
Languages were a mistake.
I assume you checked all other places in codebook?
Contributor
Author
|
Yea that is the only usage of String#toLowerCase or String#toUpperCase in the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codebook uses toLowerCase for fully upper-cased type names like UUID.
The call uses the default locale, which might incorrectly map characters
like 'I' to lowercase versions that are not 'i'.
This prevents further patching of the mache sources.
Correctly specify the ROOT locale instead, making the logic independent
from the JVM default locale.