fix: Add SheetModal and refactor modals & ED 2FA UI#736
Open
Fefedu973 wants to merge 1 commit intoPapillonApp:devfrom
Open
fix: Add SheetModal and refactor modals & ED 2FA UI#736Fefedu973 wants to merge 1 commit intoPapillonApp:devfrom
Fefedu973 wants to merge 1 commit intoPapillonApp:devfrom
Conversation
Introduce a new SheetModal component (Android-friendly animated sheet) and replace raw Modal usages with SheetModal in several screens (ED credentials, edit_subject, transport). Refactor the ÉcoleDirecte login flow: extract EDDoubleAuthModal, replace animated list item implementation with a sheet-based selectable list, add selection/submission state handling, and queue 2FA responses into the existing login flow. Update edit_subject header height calculation and minor layout tweaks. Add localized strings for double-auth description (en/fr) and import/update various UI primitives (List, Button, Typography, Papicons) and helper utilities.
Contributor
Author
|
fixes #719 |
ecnivtwelve
reviewed
Apr 7, 2026
Contributor
There was a problem hiding this comment.
Sympa, bonne initiative, mais dans l'idée d'utiliser un maximum de code natif avec l'arrivée d'Expo 55, ça pourrait être une bonne alternative d'explorer les Bottom Sheets natives :
- Lien Jetpack Compose
- Lien Expo UI
De manière à ce qu'on ne multiplie pas trop les composants à maintenir sur la durée. Peut être le wrapper dans un <NativeSheet> avec le BottomSheet iOS ou la Modal React Native
Contributor
Author
|
Ok à voir ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new SheetModal component (Android-friendly animated sheet) and replace raw Modal usages with SheetModal in several screens (ED credentials, edit_subject, transport). Refactor the ÉcoleDirecte login flow: extract EDDoubleAuthModal, replace animated list item implementation with a sheet-based selectable list, add selection/submission state handling, and queue 2FA responses into the existing login flow. Update edit_subject header height calculation and minor layout tweaks. Add localized strings for double-auth description (en/fr) and import/update various UI primitives (List, Button, Typography, Papicons) and helper utilities.
Règles de contribution
Caution
Afin de garantir une application stable et pérenne dans le temps, nous t'invitons à vérifier que tu as bien respecté les règles de contribution. Sans cela, ta Pull Request ne pourra pas être examinée.