Fixing a warn_outputdt_release_desync bug#1747
Merged
erikvansebille merged 4 commits intomasterfrom Nov 26, 2024
Merged
Conversation
Fixing a bug where `warn_outputdt_release_desync()` was unintentially raised when startime was not 0.
for more information, see https://pre-commit.ci
VeckoTheGecko
approved these changes
Nov 12, 2024
erikvansebille
requested review from
VeckoTheGecko
and removed request for
VeckoTheGecko
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a bug where
warn_outputdt_release_desync()was unintentially raised when startime was not 0.This caused the unit tests in e.g. Parcels-code/virtualship#75 to fail
Also further explaining the details of this warning