New grid object for structured grids#1966
Conversation
d7abe76 to
4f89ed5
Compare
|
@VeckoTheGecko - Do we really want to maintain a duplicate of code already provided by |
Oh yes, I should have mentioned this in the issue body. I think we should vendor as opposed to adding it as a dependency for the following reasons:
|
All good reasons. |
|
For context as well xgcm/xgcm#658 |
|
I think that this is ready for review. Post-merge we can work out how to integrate this into Field, and decide if GridAdapter is needed after all |
Note that the datasets.py file was also taken from xgcm
Remove tests that are no longer relevant
Assuming for now that left f-points are given for all Grids (which I think is an assumption that held for the grid class in Parcels v3)
1701a1a to
f52ef63
Compare
5bb7475 to
f3475cc
Compare
Also they're looking to get rid of the Axis object from the public API Lets get rid of
Hey @VeckoTheGecko sorry for the late comment (we just released xgcm 0.9.0 and I saw the link). I know we chatted about this personally, but I also wanted to state this publicly.
I would be curious what parts of the API you are using here. I do not consider the Axis/Grid as private to be honest. We abandoned the idea of dropping axis, so I do not think that will be a risk for you folks here. I also think that the grid-awareness (and associated metadata parsing) is really the 'core product' of xgcm, whereas the calculus could at this point be entirely coupled out into one or many different packages that supply grid_ufuncs. As you know my time is limited at the moment but xgcm is not dead. Might be worth checking out the new release too! |
Currently making this PR for visibility and so that we can align our approaches between #1946 and this.
Note that this PR only adds the new Grid object (along with a GridAdapter object) but doesn't use them in the larger codebase. That will be for future development.
Just to clarify, I'm not 100% sure if
GridAdapterwill make it into the final v4 and can't even particularly comment on its usefulness due to the change of state/grid manipulation done by the rest of the codebase. It might be better to bring the rest of the codebase to work with the new Grid object.v4-devfor v4 changes)cc @fluidnumerics-joe