Merged
Conversation
88fea06 to
4bc1f07
Compare
Collaborator
Author
|
@ammedd let me know if the instructions are clear. I'm going to look into real-time collaboration on the Jupyter Hub instances |
ammedd
reviewed
Feb 12, 2025
Collaborator
ammedd
left a comment
There was a problem hiding this comment.
Looks good. Mentioned some small things to improve. Wasn't able to see the gifs.
4bc1f07 to
8f8d71f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still need to test collaboration on the instances (i.e., can students log in at the same time and edit the same code) - although I need another login to do that so I'll wait for next time I'm alongside one of you Erik or Emma.
Course name is "Dynamical Oceanography" (will update)
Full instructions are on the docs site here so you can fully review.