Merged
Conversation
Collaborator
|
Works as expected: |
Collaborator
Author
|
Cool! I think we're good then. I have also added notes in the notebook (Course Facilitator notes) mentioning how to update the conda environment with the latest version of virtualship. Feel free to review the notebook |
ammedd
approved these changes
Feb 19, 2025
Collaborator
ammedd
left a comment
There was a problem hiding this comment.
Thanks! Looks good and seems to work. Will do more (general) testing this afternoon
| "```\n", | ||
| "\n", | ||
| "The `data/{your storage name}` folder is your persistent storage. This is the primary place you should store your `virtualship` configs and content relevant to this unit.\n", | ||
| "The `data/shared-storage` folder is your persistent storage. Here you can make a folder (e.g., `mkdir data/shared-storage/{your-name}` replacing `{your-name}` with your name) to house your work for the unit. This folder will be visible to anyone using the workspace, but only you will be able to make edits to it. This is the primary place you should store your `virtualship` configs and content relevant to this unit.\n", |
Collaborator
There was a problem hiding this comment.
replacing {your-name} with your name)
suggestion: add (group)
replacing {your-name} with your (group) name)
| @@ -92,11 +73,23 @@ | |||
| "virtualship /etc/miniconda/envs/virtualship`\n", | |||
Collaborator
There was a problem hiding this comment.
In line 68 remove (base) $
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the instructions to setting up the SURF environments. Now we're only using one workspace (32gb ram, 4 cores) with an attached storage (1.5Tb). Users can create their own folders in
data/shared-storage/{group-name}which everyone can see but only the user creating it can edit.@ammedd would you mind doing
cat ~/data/shared-storage/nick/text.txtandrm ~/data/shared-storage/nick/text.txtin the instance to check that the permissions work properly? The first command should show the file contents, and the second should fail.Closes #123