Conversation
j-atkins
requested review from
VeckoTheGecko
and removed request for
VeckoTheGecko
Collaborator
Author
VeckoTheGecko
requested changes
May 13, 2025
Collaborator
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Just some small changes here re. 'completing the download'
I will need to reconsider how some of the data downloading is done here and also how it is testing - not 100% happy with the current implementation (but that can be left to a future PR I think).
Collaborator
VeckoTheGecko
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #171, starting to add new biogeochemistry features. At this point this includes adding bgc data download option (O2 and chlorophyll fields added) when the new 'CTD_BGC' instrument is specified in the scheduling. Includes some commits to get branch up to date and resolve conflicts.