Conversation
VeckoTheGecko
commented
May 22, 2025
j-atkins
approved these changes
May 22, 2025
Collaborator
j-atkins
left a comment
j-atkins
left a comment
There was a problem hiding this comment.
Looks good to me! I like the restructuring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
modelssubpackage which is used to house Pydantic models and dataclasses used in the configuration of virtualship. This separation makes it easier to distinguish code for configuration vs running the simulation.This PR also cleans up the
__init__.py, cleaning up the mechanism for imports