Conversation
Collaborator
|
Anything specific you want feedback on? |
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Changes look good to me! A few comments and suggestions below
Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
erikvansebille
approved these changes
Jun 5, 2024
surgura
added a commit
that referenced
this pull request
Aug 18, 2024
* wip drifters * drifters instrument. just missing test * drifter test * Remove old drifter file and fix errors * codetools * outputdf wherever i forgot to use it * added todo list * ctd instrument * CTDtest * use new ctd instrument in sailship * fix typo * codetools * use new parcels api for particle class * add ctd to init * comments * first try adcp * adcp test * use adcp instrument in sailship * cleanup * instrument ship s t * use ship st in sailship * cleanup * refactor sailship ctd cast * cleanup * large cleanup * add checks that all drifter and argo floats are deployed * comments * docstrings and other codetools fixes * rename SamplePoint to Spacetime and move them one dir up * rm todo * run pydocstyle on tests * fix some names * Update virtual_ship/instruments/ctd.py Co-authored-by: Erik van Sebille <erikvansebille@gmail.com> * removed comment about ctd * fix incorrect docstring * renamed ship_st to ship_underwater_st * remove sailship create fieldset commented out function * ship underway st docstring improvement * minor docstring change * minor docstring change --------- Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
VeckoTheGecko
pushed a commit
that referenced
this pull request
Sep 25, 2024
* wip drifters * drifters instrument. just missing test * drifter test * Remove old drifter file and fix errors * codetools * outputdf wherever i forgot to use it * added todo list * ctd instrument * CTDtest * use new ctd instrument in sailship * fix typo * codetools * use new parcels api for particle class * add ctd to init * comments * first try adcp * adcp test * use adcp instrument in sailship * cleanup * instrument ship s t * use ship st in sailship * cleanup * refactor sailship ctd cast * cleanup * large cleanup * add checks that all drifter and argo floats are deployed * comments * docstrings and other codetools fixes * rename SamplePoint to Spacetime and move them one dir up * rm todo * run pydocstyle on tests * fix some names * Update virtual_ship/instruments/ctd.py Co-authored-by: Erik van Sebille <erikvansebille@gmail.com> * removed comment about ctd * fix incorrect docstring * renamed ship_st to ship_underwater_st * remove sailship create fieldset commented out function * ship underway st docstring improvement * minor docstring change * minor docstring change --------- Co-authored-by: Erik van Sebille <erikvansebille@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> tests for instruments are incomplete and their actual results are most likely incorrect. This will be the next step.