Merged
Conversation
Comment on lines
449
to
456
| land_waypoints = [ | ||
| (wp_i, wp) | ||
| for wp_i, wp in enumerate(waypoints) | ||
| if fieldset.UV.eval( | ||
| 0, 0, wp.location.lat, wp.location.lon, applyConversion=False | ||
| ) | ||
| == (0.0, 0.0) | ||
| ] |
Member
There was a problem hiding this comment.
Make this a more general method, so that someone could later change the way in which landpoints are defined (e.g. through a mask-array, instead of zero-velocity condition)
erikvansebille
approved these changes
Aug 12, 2024
surgura
added a commit
that referenced
this pull request
Aug 18, 2024
* verify waypoints are on water * Make zero uv on land check a function * add test for sailship verify * comments
VeckoTheGecko
pushed a commit
that referenced
this pull request
Sep 25, 2024
* verify waypoints are on water * Make zero uv on land check a function * add test for sailship verify * comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verified when checking the waypoints, not during simulation
closes #25