Added url safe base64 encoding#12
Merged
icflournoy merged 2 commits intoparrableIdSystem/basefrom Jan 27, 2021
Merged
Conversation
icflournoy
reviewed
Jan 21, 2021
modules/parrableIdSystem.js
Outdated
| return true; | ||
| } | ||
|
|
||
| function encodeBase64Safe(base64) { |
There was a problem hiding this comment.
this should be encodeBase64UrlSafe since "url safe" is how this encoding is referenced in public documents.
icflournoy
suggested changes
Jan 25, 2021
icflournoy
left a comment
icflournoy
left a comment
There was a problem hiding this comment.
Can you see if we're able to stub the btoa function and return our own base64 so that we can force this function to translate characters, then make an assertion on the Xhr mock?
victorigualada
force-pushed
the
parrableIdSystem/PBID-74
branch
from
a8b255a to
8da0c8b
Compare
victorigualada
force-pushed
the
parrableIdSystem/PBID-74
branch
from
8da0c8b to
23537a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added URL base64 safe encoding