PBID-80: Improve parrableIdSystem timezone documentation#16
Merged
icflournoy merged 3 commits intoparrableIdSystem/PBID-80_lowercase_timezonefrom Feb 5, 2021
Merged
PBID-80: Improve parrableIdSystem timezone documentation#16icflournoy merged 3 commits intoparrableIdSystem/PBID-80_lowercase_timezonefrom
icflournoy merged 3 commits intoparrableIdSystem/PBID-80_lowercase_timezonefrom
Conversation
icflournoy
suggested changes
Feb 2, 2021
icflournoy
left a comment
icflournoy
left a comment
There was a problem hiding this comment.
the same lowercasing needs to be done for all configurable allowed/blocked zones and offsets
Author
Offsets are numbers right? so no lowered case needed |
yes correct! |
icflournoy
suggested changes
Feb 4, 2021
icflournoy
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs PR: Parrable/prebid.github.io#4