Add Confirmation Prompt for Potentially Harmful Task Removals#2
Open
0danteh wants to merge 1 commit into
Open
Conversation
This commit introduces a new safety feature in the 'tasksel' tool to prevent accidental removal of critical system tasks. A confirmation prompt is added to the removal process for tasks that are identified as potentially harmful. Key Changes: - Defined a list of critical tasks (`@harmful_cmd`) that are considered dangerous to remove. This list can be modified to include any task that is crucial for system stability. - Modified the `getopts` function to include a check against this list when processing a `remove` command. If the command involves any of these harmful tasks, the user is prompted to confirm their intention. - Implemented a confirmation prompt that requires explicit user approval (input 'Y') to proceed with the removal. If the user responds with 'N' or any other input, the script immediately exits, thereby stopping the removal process. - This feature adds an extra layer of protection against inadvertent system damage, especially for users who might not be fully aware of the consequences of removing certain tasks. Testing: - Extensive testing is recommended to ensure that the new confirmation prompt behaves correctly under various scenarios and does not disrupt the intended functionality of 'tasksel'. - The list of harmful commands should be reviewed and updated as needed based on the specific use case and system requirements. This change aims to enhance the usability and safety of 'tasksel', particularly in environments where accidental removal of critical tasks could lead to significant system issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new safety feature in the 'tasksel' tool to prevent accidental removal of critical system tasks. A confirmation prompt is added to the removal process for tasks that are identified as potentially harmful.
Key Changes:
@harmful_cmd) that are considered dangerous to remove. This list can be modified to include any task that is crucial for system stability.getoptsfunction to include a check against this list when processing aremovecommand. If the command involves any of these harmful tasks, the user is prompted to confirm their intention.Testing:
This change aims to enhance the usability and safety of 'tasksel', particularly in environments where accidental removal of critical tasks could lead to significant system issues.