[CDM] - Registrar jobs de acciones masivas#66
Merged
NahuelProdu merged 3 commits intomasterfrom Jan 6, 2025
Merged
Conversation
lclauser
reviewed
Nov 6, 2024
Comment on lines
+25
to
+27
| @isJob = _.get(payload, 'notification.message.JobId'); | ||
|
|
||
| @deliveryStreamName = if @isJob then @jobsDeliveryStream else @deliveryStream |
Contributor
There was a problem hiding this comment.
el @ es un this en coffee
no queremos estar seteando atributos asi en la instancia, que sean variables normales, no atributos de la instancia
| { | ||
| type: @_retrieveMessageFromError warning, TYPE_PROPERTIES, "unknown" | ||
| message: @_retrieveMessageFromError warning, MESSAGE_PROPERTIES, "" | ||
| id |
Contributor
There was a problem hiding this comment.
ya que extraemos el otro caso a una funcion por ahi tiene sentido que este tambien a otra
lclauser
approved these changes
Nov 11, 2024
lclauser
reviewed
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes #7296454998