feat: agrego shouldretry antes del process, corrijo script#96
Merged
MariKevorkyan merged 2 commits intomasterfrom Apr 16, 2026
Merged
feat: agrego shouldretry antes del process, corrijo script#96MariKevorkyan merged 2 commits intomasterfrom
MariKevorkyan merged 2 commits intomasterfrom
Conversation
|
🚀 Próximo bump: |
lclauser
reviewed
Apr 16, 2026
| constructor: ({ @processor, @maxRetries = 3 }) -> | ||
|
|
||
| process: (notification, context, executionId) -> | ||
| @_onMaxRetryExceeded_ notification, new Error("max retries exceeded") unless @_shouldRetry_ notification |
Contributor
There was a problem hiding this comment.
el onMaxRetryExceeded tira un error sincronico, no una promise rejectada, ese cambio de interfaz esta bien?
no se si esta dentro ya de un flujo de promises
gastonprieto
approved these changes
Apr 16, 2026
MatiasVillanueva97
approved these changes
Apr 16, 2026
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes #11768504311