Skip to content

feat!: dont use context.done #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gimenez-ivan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat!: dont use context.done #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions src/processor.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,15 @@ module.exports =

_isIgnoredError = (error) => error instanceof IgnoredError

execute()
.tap => @_emitEvent "successful", { context, id, notification }
.catch _isIgnoredError, (error) =>
@_emitEvent "successful", { context, id, notification, warnings: [error] }
.catch (error) =>
throw error unless error instanceof NonRetryable
@_emitEvent "unsuccessful_non_retryable", { context, id, notification, error }
.tapCatch (error) => @_emitEvent "unsuccessful", { context, id, notification, error }
.finally => @_emitEvent "finished", { context, id, notification }
.asCallback context.done

return

return execute()
.tap => @_emitEvent "successful", { context, id, notification }
.catch _isIgnoredError, (error) =>
@_emitEvent "successful", { context, id, notification, warnings: [error] }
.catch (error) =>
throw error unless error instanceof NonRetryable
@_emitEvent "unsuccessful_non_retryable", { context, id, notification, error }
.tapCatch (error) => @_emitEvent "unsuccessful", { context, id, notification, error }
.finally => @_emitEvent "finished", { context, id, notification }

_emitEvent: (eventName, value) =>
@emit eventName, value if ENABLE_EVENTS
Loading