Updating build action to include provenance #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced multiple tagging commands with a single one
johnsimons
commented
Feb 10, 2025
| Invoke-Expression $cmd | ||
| Write-Output "::endgroup::" | ||
| } | ||
| $tagsCLI = $tags -replace "^", "--tag particular/servicecontrol-masstransit-connector:" |
Member
Author
There was a problem hiding this comment.
Replaced multiple commands with a single command
johnsimons
commented
Feb 10, 2025
| run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ghcr.io |
Member
Author
There was a problem hiding this comment.
Using the Github action to authenticate to Github registry
johnsimons
commented
Feb 10, 2025
| docker buildx imagetools inspect ghcr.io/particular/servicecontrol-masstransit-connector:${{ env.TAG_NAME }} | ||
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ghcr.io |
Member
Author
There was a problem hiding this comment.
Using the Github action to authenticate to Github registry
johnsimons
commented
Feb 10, 2025
| id: date | ||
| run: echo "::set-output name=date::$(date +'+%FT%TZ')" | ||
| - name: Build and push image to GitHub container registry | ||
| uses: docker/build-push-action@v6 |
Member
Author
There was a problem hiding this comment.
Using Github action to push and tag image.
This will use provenance
johnsimons
force-pushed
the
john/native
branch
3 times, most recently
from
74b4a22 to
0b38e43
Compare
Using build-push-action instead of script This adds the provenance by default, see https://docs.docker.com/build/ci/github-actions/attestations/#default-provenance This given the image a better score in dockerhub scout health score
johnsimons
force-pushed
the
john/native
branch
from
0b38e43 to
6eddac1
Compare
irinascurtu
approved these changes
Feb 12, 2025
This was referenced Feb 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix
